From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7D47C47092 for ; Tue, 1 Jun 2021 14:59:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE14161263 for ; Tue, 1 Jun 2021 14:59:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234451AbhFAPBN (ORCPT ); Tue, 1 Jun 2021 11:01:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46823 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234393AbhFAPBJ (ORCPT ); Tue, 1 Jun 2021 11:01:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622559567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=vBakIu1dQtk22INC/4X9gLrUw+kGXTDgbjVD36Rzgzs=; b=fbeXQH4rXt7j5/AAE7GpIxdM1cQGYZV2vi9QDB5jzsgtr6ogRetNHJEL1H5nZll+6XjrPq eilb1OccATUY2yGp7homxPWPdxEX8Xluh1idSOiFwiorxkiA1wKH4D0Os8uDLqb+ejPqaP 2W9N1Lua66gh9eOxm8EOsNgCXr6Refg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-153--HyZWk61MK-f-tn7ujNUNQ-1; Tue, 01 Jun 2021 10:59:25 -0400 X-MC-Unique: -HyZWk61MK-f-tn7ujNUNQ-1 Received: by mail-wm1-f72.google.com with SMTP id z25-20020a1c4c190000b029019f15b0657dso606018wmf.8 for ; Tue, 01 Jun 2021 07:59:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vBakIu1dQtk22INC/4X9gLrUw+kGXTDgbjVD36Rzgzs=; b=N+n9T8hRz3wFJjFWQuob2yDf9+fbMb6GgsTvHvS05FZHNzd2iTigw4iS00GZfJUHnN uOOBgaV2Jn1rir3zA6Rdg4P7pf3ZG4IMF88BBeZnHikeVl12AG1pq7g6jDbdB4vXjE2B M0fzhaLvz/+tJyChCLFDJhithj11WqNZCR1sQL7dXFy5Fg1wEue8Gmj2UYonRgw0zi6j uTWopIZr5czaRS3DhTtFumQld0AcRLjpWAppJnD/zOMbSAX1Wqybzn27o88H5gdX4U4j ntGbmzQ8b6/ol46AWUDaj4e7i3mm97Gh0V+18HnOsdA73/B/EAERRG0WuI+/iL+eQWox rPrA== X-Gm-Message-State: AOAM533BhoFA9d1k9sKlC+hK61y81FBbtZvLpiwTpC3OoKgs2U4i8tOM KNc+ummICh9nj35lpSrnS67PhZZ3ZuGZZtw90jg007W9nmPgPIgZDzY5SXgGvjLXt8OBrYRFynh gPMS4SKvcmkUYtEB5jPBHgLXsP04V0tIvzU/0dLNfecyVMwUUz7JMsLc6LGFV6yaqeoEzDUORWu o= X-Received: by 2002:a1c:282:: with SMTP id 124mr350848wmc.82.1622559564400; Tue, 01 Jun 2021 07:59:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9XbrF5UjA3Lkw2unmQqkjrGQdtKb1lFgUux9RmxthjhbwQ8B+MLPzmwDX65DDh6SYfSo0EA== X-Received: by 2002:a1c:282:: with SMTP id 124mr350790wmc.82.1622559564069; Tue, 01 Jun 2021 07:59:24 -0700 (PDT) Received: from minerva.redhat.com ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id h6sm3533153wrt.6.2021.06.01.07.59.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:59:23 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Hans de Goede , Peter Robinson , dri-devel@lists.freedesktop.org, Daniel Vetter , Thomas Zimmermann , David Airlie , Javier Martinez Canillas , Albert Ou , Andy Shevchenko , Ard Biesheuvel , Arvind Sankar , Bjorn Andersson , Borislav Petkov , Brijesh Singh , Catalin Marinas , Chester Lin , Dinh Nguyen , Greg Kroah-Hartman , "H. Peter Anvin" , Ingo Molnar , Joerg Roedel , John Stultz , Josh Poimboeuf , Juergen Gross , Kalle Valo , Krzysztof Kozlowski , Linus Walleij , Nicolas Saenz Julienne , Palmer Dabbelt , Paul Walmsley , "Peter Zijlstra (Intel)" , Russell King , Sudeep Holla , Thomas Gleixner , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org Subject: [PATCH v2 0/2] allow simple{fb,drm} drivers to be used on non-x86 EFI platforms Date: Tue, 1 Jun 2021 16:59:10 +0200 Message-Id: <20210601145912.774054-1-javierm@redhat.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The simplefb and simpledrm drivers match against a "simple-framebuffer" device, but for aarch64 this is only registered when using Device Trees and there's a node with a "simple-framebuffer" compatible string. There is no code to register a "simple-framebuffer" platform device when using EFI instead. In fact, the only platform device that's registered in this case is an "efi-framebuffer", which means that the efifb driver is the only driver supported to have an early console with EFI on aarch64. The x86 architecture platform has a Generic System Framebuffers (sysfb) support, that register a system frambuffer platform device. It either registers a "simple-framebuffer" for the simple{fb,drm} drivers or legacy VGA/EFI FB devices for the vgafb/efifb drivers. The sysfb is generic enough to be reused by other architectures and can be moved out of the arch/x86 directory to drivers/firmware, allowing the EFI logic used by non-x86 architectures to be folded into sysfb as well. Patch #1 in this series do the former while patch #2 do the latter. It has been tested on x86_64 and aarch64 machines using the efifb, simplefb and simpledrm drivers. But more testing will be highly appreciated, to make sure that no regressions are being introduced by these changes. The series touches different subystems and will need coordination between maintainers. Ard Biesheuvel said that can be merged through the EFI tree. Best regards, Javier Changes in v2: - Use default y and depends on X86 instead doing a select in arch/x86/Kconfig. - Also enable the SYSFB Kconfig option when COMPILE_TEST. - Improve commit message to explain why is useful for other arches to use this. - Use "depends on" for the supported architectures instead of selecting it. - Improve commit message to explain the benefits of reusing sysfb for !X86. Javier Martinez Canillas (2): drivers/firmware: move x86 Generic System Framebuffers support drivers/firmware: consolidate EFI framebuffer setup for all arches arch/arm/include/asm/efi.h | 5 +- arch/arm64/include/asm/efi.h | 5 +- arch/riscv/include/asm/efi.h | 5 +- arch/x86/Kconfig | 26 ------ arch/x86/kernel/Makefile | 3 - drivers/firmware/Kconfig | 32 +++++++ drivers/firmware/Makefile | 2 + drivers/firmware/efi/Makefile | 2 + drivers/firmware/efi/efi-init.c | 90 ------------------- .../firmware/efi}/sysfb_efi.c | 79 +++++++++++++++- {arch/x86/kernel => drivers/firmware}/sysfb.c | 42 +++++---- .../firmware}/sysfb_simplefb.c | 31 ++++--- .../x86/include/asm => include/linux}/sysfb.h | 34 +++---- 13 files changed, 180 insertions(+), 176 deletions(-) rename {arch/x86/kernel => drivers/firmware/efi}/sysfb_efi.c (84%) rename {arch/x86/kernel => drivers/firmware}/sysfb.c (70%) rename {arch/x86/kernel => drivers/firmware}/sysfb_simplefb.c (82%) rename {arch/x86/include/asm => include/linux}/sysfb.h (68%) -- 2.31.1