From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ojaswin Mujoo <ojaswin98@gmail.com>
Cc: nsaenz@kernel.org, gregkh@linuxfoundation.org, arnd@arndb.de,
phil@raspberrypi.com, bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: staging: vc04_services: Need suggestions on trying to fix sparse warning in vchiq_arm.c
Date: Tue, 1 Jun 2021 23:23:07 +0300 [thread overview]
Message-ID: <20210601202307.GC1955@kadam> (raw)
In-Reply-To: <20210601200513.GA10204@ojas>
The problem is not the Sparse warning, the problem is that this code is
a mess. It used to very clearly buggy and I reported the bug. I think
Arnd found the bug again independently and fixed it.
A couple weeks ago Al Viro looked at this code. Here is his write up:
https://www.spinics.net/lists/kernel/msg3952745.html
It shouldn't take Al Viro dozens of pages of detailed analysis to try
figure out if the code is safe or not. Your idea silences the warning
but would make the code even more subtle and complicated.
The right thing to do is to re-write the code to be simpler.
regards,
dan carpenter
next prev parent reply other threads:[~2021-06-01 20:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 20:05 staging: vc04_services: Need suggestions on trying to fix sparse warning in vchiq_arm.c Ojaswin Mujoo
2021-06-01 20:23 ` Dan Carpenter [this message]
2021-06-02 14:50 ` Ojaswin Mujoo
2021-06-04 6:13 ` Stefan Wahren
2021-06-05 7:23 ` Ojaswin Mujoo
2021-06-05 8:41 ` Stefan Wahren
2021-06-06 9:26 ` Ojaswin Mujoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601202307.GC1955@kadam \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nsaenz@kernel.org \
--cc=ojaswin98@gmail.com \
--cc=phil@raspberrypi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).