From: Jarmo Tiitto <jarmo.tiitto@gmail.com>
To: Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux@googlegroups.com
Cc: Jarmo Tiitto <jarmo.tiitto@gmail.com>,
samitolvanen@google.com, morbo@google.com, keescook@chromium.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] pgo: Fix allocate_node() handling of non-vmlinux nodes
Date: Wed, 2 Jun 2021 03:57:02 +0300 [thread overview]
Message-ID: <20210602005702.9650-1-jarmo.tiitto@gmail.com> (raw)
Currently allocate_node() will reserve nodes even if *p
doesn't point into __llvm_prf_data_start - __llvm_prf_data_end
range.
This is wrong:
Any instrumented modules that are not part of vmlinux
(built-in) will "steal" available nodes away from vmlinux.
This can result in exhaustion of nodes for vmlinux
and less accurate profile data.
Either way, any profiling data generated by loaded modules,
if any, is unusable from vmlinux.profraw.
So just filtter them out.
Jarmo Tiitto (1):
pgo: Fix allocate_node() handling of non-vmlinux nodes.
kernel/pgo/instrument.c | 4 ++++
1 file changed, 4 insertions(+)
--
2.31.1
next reply other threads:[~2021-06-02 1:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 0:57 Jarmo Tiitto [this message]
2021-06-02 0:57 ` [PATCH 1/1] pgo: Fix allocate_node() handling of non-vmlinux nodes Jarmo Tiitto
2021-06-02 17:41 ` Kees Cook
2021-06-02 18:52 ` jarmo.tiitto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210602005702.9650-1-jarmo.tiitto@gmail.com \
--to=jarmo.tiitto@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).