From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FFEBC47080 for ; Tue, 1 Jun 2021 23:48:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BC02613F6 for ; Tue, 1 Jun 2021 23:48:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235197AbhFAXuh (ORCPT ); Tue, 1 Jun 2021 19:50:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:53296 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235034AbhFAXug (ORCPT ); Tue, 1 Jun 2021 19:50:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 97CAC613B4; Tue, 1 Jun 2021 23:48:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622591334; bh=L5TBPUeRAk35Q5KL49H1pE9FXn6EXJ/5i7usvcJ4g2g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Osm0zNOwf+weSGzuGiJV4iyG6FvfX2RvIsSYStZcYKZjChPL/PNeFlIJvg7dqEOFB 0FFpiscmEhDn3dav7HZWsNago+DtlYO8XuT+mOa8iNNVvYdq3hKfnmhg+RXQasE166 QqWD8U6fNi78DwlmEDE0Ay2U50oqsQTiWJ3wdaWZ2fFCJ/dFsoTUFtsjRcxnU/MCuq YtmNqEavToCk7NGfDq07wAXP208GDwRgYDwAnMn3BOrh2wmPJEPORwHYBZweqGg1zk yg41CNSoi+FjpjsBiVnprGN3PrlYKj8MjCP78OHZOwch0HIFDBY74Ev8iedkmgENGD 39DGs8pmMPRDA== Date: Wed, 2 Jun 2021 08:48:50 +0900 From: Masami Hiramatsu To: Peter Zijlstra Cc: "Naveen N. Rao" , mhiramat@kernel.org, ananth@linux.ibm.com, Christoph Hellwig , linux-kernel@vger.kernel.org, mingo@kernel.org, rostedt@goodmis.org, x86@kernel.org Subject: Re: [PATCH] kprobes: Do not increment probe miss count in the fault handler Message-Id: <20210602084850.598a60d848a7bdc7c3b0085a@kernel.org> In-Reply-To: References: <20210525073213.561116662@infradead.org> <20210601120150.672652-1-naveen.n.rao@linux.vnet.ibm.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Jun 2021 15:20:32 +0200 Peter Zijlstra wrote: > On Tue, Jun 01, 2021 at 05:31:50PM +0530, Naveen N. Rao wrote: > > Kprobes has a counter 'nmissed', that is used to count the number of > > times a probe handler was not called. This generally happens when we hit > > a kprobe while handling another kprobe. > > > > However, if one of the probe handlers causes a fault, we are currently > > incrementing 'nmissed'. The comment in fault handler indicates that this > > can be used to account faults taken by the probe handlers. But, this has > > never been the intention as is evident from the comment above 'nmissed' > > in 'struct kprobe': > > > > /*count the number of times this probe was temporarily disarmed */ > > unsigned long nmissed; > > > > Signed-off-by: Naveen N. Rao > > --- > > I'm posting this here so that these can go together, if the patch is ok > > otherwise. > > I had the other two queued in perf/core and was about to push then to > tip, Masami are you good with adding this on top? Yes, those looks good to me too. Acked-by: Masami Hiramatsu Thank you, -- Masami Hiramatsu