* [PATCH v2] ACPI: FPDT: Add the missed acpi_put_table() in acpi_init_fpdt()
@ 2021-06-02 11:58 Jing Xiangfeng
2021-06-03 1:02 ` Hanjun Guo
2021-06-07 13:59 ` Rafael J. Wysocki
0 siblings, 2 replies; 3+ messages in thread
From: Jing Xiangfeng @ 2021-06-02 11:58 UTC (permalink / raw)
To: rjw, lenb, rui.zhang, guohanjun; +Cc: linux-acpi, linux-kernel, jingxiangfeng
acpi_init_fpdt() misses to call acpi_put_table() in an error path. Add
the missed function call to fix it.
Fixes: d1eb86e59be0 ("ACPI: tables: introduce support for FPDT table")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Acked-by: Zhang Rui <rui.zhang@intel.com>
---
v1 -> v2:
- Collect Acked-by tag by Zhang Rui.
- retitle the subject as suggested by Hanjun Guo.
---
drivers/acpi/acpi_fpdt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c
index a89a806a7a2a..4ee2ad234e3d 100644
--- a/drivers/acpi/acpi_fpdt.c
+++ b/drivers/acpi/acpi_fpdt.c
@@ -240,8 +240,10 @@ static int __init acpi_init_fpdt(void)
return 0;
fpdt_kobj = kobject_create_and_add("fpdt", acpi_kobj);
- if (!fpdt_kobj)
+ if (!fpdt_kobj) {
+ acpi_put_table(header);
return -ENOMEM;
+ }
while (offset < header->length) {
subtable = (void *)header + offset;
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ACPI: FPDT: Add the missed acpi_put_table() in acpi_init_fpdt()
2021-06-02 11:58 [PATCH v2] ACPI: FPDT: Add the missed acpi_put_table() in acpi_init_fpdt() Jing Xiangfeng
@ 2021-06-03 1:02 ` Hanjun Guo
2021-06-07 13:59 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Hanjun Guo @ 2021-06-03 1:02 UTC (permalink / raw)
To: Jing Xiangfeng, rjw, lenb, rui.zhang; +Cc: linux-acpi, linux-kernel
On 2021/6/2 19:58, Jing Xiangfeng wrote:
> acpi_init_fpdt() misses to call acpi_put_table() in an error path. Add
> the missed function call to fix it.
>
> Fixes: d1eb86e59be0 ("ACPI: tables: introduce support for FPDT table")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> Acked-by: Zhang Rui <rui.zhang@intel.com>
> ---
> v1 -> v2:
> - Collect Acked-by tag by Zhang Rui.
> - retitle the subject as suggested by Hanjun Guo.
> ---
> drivers/acpi/acpi_fpdt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c
> index a89a806a7a2a..4ee2ad234e3d 100644
> --- a/drivers/acpi/acpi_fpdt.c
> +++ b/drivers/acpi/acpi_fpdt.c
> @@ -240,8 +240,10 @@ static int __init acpi_init_fpdt(void)
> return 0;
>
> fpdt_kobj = kobject_create_and_add("fpdt", acpi_kobj);
> - if (!fpdt_kobj)
> + if (!fpdt_kobj) {
> + acpi_put_table(header);
> return -ENOMEM;
> + }
>
> while (offset < header->length) {
> subtable = (void *)header + offset;
Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ACPI: FPDT: Add the missed acpi_put_table() in acpi_init_fpdt()
2021-06-02 11:58 [PATCH v2] ACPI: FPDT: Add the missed acpi_put_table() in acpi_init_fpdt() Jing Xiangfeng
2021-06-03 1:02 ` Hanjun Guo
@ 2021-06-07 13:59 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2021-06-07 13:59 UTC (permalink / raw)
To: Jing Xiangfeng
Cc: Rafael J. Wysocki, Len Brown, Zhang, Rui, Hanjun Guo,
ACPI Devel Maling List, Linux Kernel Mailing List
On Wed, Jun 2, 2021 at 1:44 PM Jing Xiangfeng <jingxiangfeng@huawei.com> wrote:
>
> acpi_init_fpdt() misses to call acpi_put_table() in an error path. Add
> the missed function call to fix it.
>
> Fixes: d1eb86e59be0 ("ACPI: tables: introduce support for FPDT table")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> Acked-by: Zhang Rui <rui.zhang@intel.com>
> ---
> v1 -> v2:
> - Collect Acked-by tag by Zhang Rui.
> - retitle the subject as suggested by Hanjun Guo.
> ---
> drivers/acpi/acpi_fpdt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c
> index a89a806a7a2a..4ee2ad234e3d 100644
> --- a/drivers/acpi/acpi_fpdt.c
> +++ b/drivers/acpi/acpi_fpdt.c
> @@ -240,8 +240,10 @@ static int __init acpi_init_fpdt(void)
> return 0;
>
> fpdt_kobj = kobject_create_and_add("fpdt", acpi_kobj);
> - if (!fpdt_kobj)
> + if (!fpdt_kobj) {
> + acpi_put_table(header);
> return -ENOMEM;
> + }
>
> while (offset < header->length) {
> subtable = (void *)header + offset;
> --
Applied as 5.14 material with some edits in the subject and changelog, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-07 13:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-02 11:58 [PATCH v2] ACPI: FPDT: Add the missed acpi_put_table() in acpi_init_fpdt() Jing Xiangfeng
2021-06-03 1:02 ` Hanjun Guo
2021-06-07 13:59 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).