From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 162C7C47083 for ; Wed, 2 Jun 2021 13:52:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2C74613D6 for ; Wed, 2 Jun 2021 13:52:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230025AbhFBNyO (ORCPT ); Wed, 2 Jun 2021 09:54:14 -0400 Received: from meesny.iki.fi ([195.140.195.201]:32902 "EHLO meesny.iki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229767AbhFBNyN (ORCPT ); Wed, 2 Jun 2021 09:54:13 -0400 Received: from hillosipuli.retiisi.eu (unknown [IPv6:2001:2003:f75d:b010::e64]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sailus) by meesny.iki.fi (Postfix) with ESMTPSA id F2FA8201E0; Wed, 2 Jun 2021 16:52:27 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1622641948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XasE4YAlNMR4WrY6dbX8b0zZWRhV24uifEW0Tnx0hOw=; b=cqoamrpMrsiGqJXo3AYGEX/BGroPhrmZJN5P8mYFRLehd+o3Y/MiWQy4tZ7JLczMmSjzfb SYptjivwo02pWcr6HE27e3Ma3rnJy7GL6WArjTaZAHFnPL0E8bEY6stT8oKH+pbus0lWbW Km/uOJ2AMxNRmCy+vgQE3BqZMZd1aRg= Received: from valkosipuli.localdomain (valkosipuli.localdomain [IPv6:fd35:1bc8:1a6:d3d5::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.eu (Postfix) with ESMTPS id 9C9D8634C87; Wed, 2 Jun 2021 16:51:34 +0300 (EEST) Received: from localhost ([127.0.0.1] helo=valkosipuli.retiisi.eu) by valkosipuli.localdomain with esmtp (Exim 4.92) (envelope-from ) id 1loRIJ-0002Uv-Ig; Wed, 02 Jun 2021 16:52:27 +0300 Date: Wed, 2 Jun 2021 16:52:27 +0300 From: Sakari Ailus To: Laurent Pinchart Cc: Martin Kepplinger , mchehab@kernel.org, devicetree@vger.kernel.org, kernel@puri.sm, krzysztof.kozlowski@canonical.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, paul.kocialkowski@bootlin.com, robh@kernel.org, shawnx.tu@intel.com Subject: Re: [PATCH v2 2/5] dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor Message-ID: <20210602135226.GX3@valkosipuli.retiisi.eu> References: <20210528081336.3858700-1-martin.kepplinger@puri.sm> <20210528081336.3858700-3-martin.kepplinger@puri.sm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=sailus smtp.mailfrom=sakari.ailus@iki.fi ARC-Seal: i=1; s=meesny; d=iki.fi; t=1622641948; a=rsa-sha256; cv=none; b=yq3M8su7tNeLBYbQnxlIWE0xAZhDsPrQRCwhIaP9RldbEP/MGJWm/XhOSvzge40u7znPjj katd2z9xG91TN5OFQLlbOuJuZPeCVMglZdFFY4iMB4fm7KONcV0oraTQd3EOWTz3bvkwQ5 tk79trHHMZeLqoh5mqcyCPdypFZXDPY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1622641948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XasE4YAlNMR4WrY6dbX8b0zZWRhV24uifEW0Tnx0hOw=; b=fnEa+jVXXHiczG9qsdnq1esoEoyqjPKbg10uvYRTxfNCFx3VfnTCRNCiXM7aTlaUWkuwXR +QKYETJssz2s187unMG62ION4pGBItem3P4m3Q7Eiw8F0nwILKi5cW2KqWFjKHaciuV2oS dIjCfTKCwojtbpc0+zXfWog8+Iq1hvg= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 28, 2021 at 11:35:35AM +0300, Laurent Pinchart wrote: ... > > + maxItems: 1 > > + > > + clocks: > > + description: Reference to the mclk clock. > > + maxItems: 1 > > You could also write this > > clocks: > items: > - description: Reference to the mclk clock. > > The maxItems will then be implicit. This is the preferred form when > multiple clocks are used, and given that clocks it meant to contain a > list of clocks, even if it has a single entry, placing the description > in a list of items may be a bit better semantically speaking. > > > + > > + clock-names: > > + const: mclk > > Similarly, > > clock-names: > items: > - const: mclk > > Rob, is standardizing this pattern a good idea, or do you prefer the > shorter form > > clock-names: > const: mclk As there's just one clock, isn't the clock-names redundant? -- Sakari Ailus