linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Martin Kepplinger <martin.kepplinger@puri.sm>,
	mchehab@kernel.org, devicetree@vger.kernel.org, kernel@puri.sm,
	krzysztof.kozlowski@canonical.com, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, paul.kocialkowski@bootlin.com,
	robh@kernel.org, shawnx.tu@intel.com
Subject: Re: [PATCH v2 2/5] dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor
Date: Wed, 2 Jun 2021 17:37:26 +0300	[thread overview]
Message-ID: <20210602143726.GZ3@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <YLeQGjDdTX0iohZ0@pendragon.ideasonboard.com>

Hi Laurent,

On Wed, Jun 02, 2021 at 05:05:14PM +0300, Laurent Pinchart wrote:
> On Wed, Jun 02, 2021 at 04:51:37PM +0300, Sakari Ailus wrote:
> > Hi Martin,
> > 
> > On Fri, May 28, 2021 at 10:13:33AM +0200, Martin Kepplinger wrote:
> > > Document the bindings used for the SK Hynix Hi-846 CMOS camera driver.
> > > 
> > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> > 
> > Could you read Documentation/driver-api/media/camera-sensor.rst, please?
> > 
> > I believe you'll need assigned-clock-rates device property as well as
> 
> I dn't think assigned-clock-rates should be part of the bindings, it's a
> mechanism that can be used in any DT device node.

What if it's required?

> 
> > link-frequencies endpoint property.
> > 
> > > ---
> > >  .../bindings/media/i2c/hynix,hi846.yaml       | 99 +++++++++++++++++++
> > >  1 file changed, 99 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> > > 
> > > diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> > > new file mode 100644
> > > index 000000000000..2991108e23e5
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> > > @@ -0,0 +1,99 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/media/i2c/hynix,hi846.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: SK Hynix Hi-846 1/4" 8M Pixel MIPI CSI-2 sensor
> > > +
> > > +maintainers:
> > > +  - Martin Kepplinger <martin.kepplinger@puri.sm>
> > > +
> > > +description: |-
> > > +  The Hi-846 is a raw image sensor with an MIPI CSI-2 image data
> > > +  interface and CCI (I2C compatible) control bus. The output format
> > > +  is 10bit Bayer.
> > 
> > Virtually all Bayer sensors can do 8 bpp, too. I'd drop the sentence
> 
> Not this one according to its datasheet (we can't rule out that this
> would be possible an undocumented of course).

Ok, fair enough.

> 
> > mentoning 10 bits.
> > 
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: hynix,hi846
> > > +
> > > +  reg:
> > > +    description: I2C device address.
> > > +    maxItems: 1
> > > +
> > > +  clocks:
> > > +    description: Reference to the mclk clock.
> > > +    maxItems: 1
> > > +
> > > +  clock-names:
> > > +    const: mclk
> > > +
> > > +  rst-gpios:
> > > +    description: Reference to the GPIO connected to the reset pin. Active low.
> > > +    maxItems: 1
> > > +
> > > +  vdd-supply:
> > > +    description: Definition of the regulator used as 1.8V digital power supply.
> > > +
> > > +  port:
> > > +    $ref: /schemas/graph.yaml#/properties/port
> > > +    additionalProperties: false
> > > +
> > > +    properties:
> > > +      endpoint:
> > > +        $ref: /schemas/media/video-interfaces.yaml#
> > > +        unevaluatedProperties: false
> > > +
> > > +        properties:
> > > +          data-lanes:
> > > +            oneOf:
> > > +              - items:
> > > +                  - const: 1
> > > +                  - const: 2
> > > +                  - const: 3
> > > +                  - const: 4
> > > +              - items:
> > > +                  - const: 1
> > > +                  - const: 2
> > > +
> > > +        required:
> > > +          - data-lanes
> > > +
> > > +required:
> > > +  - compatible
> > > +  - reg
> > > +  - clocks
> > > +  - clock-names
> > > +  - rst-gpios
> > > +  - vdd-supply
> > > +  - port
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > +  - |
> > > +    #include <dt-bindings/gpio/gpio.h>
> > > +
> > > +    i2c {
> > > +        #address-cells = <1>;
> > > +        #size-cells = <0>;
> > > +
> > > +        hi846: camera@20 {
> > > +            compatible = "hynix,hi846";
> > > +            reg = <0x20>;
> > > +            clocks = <&clk>;
> > > +            clock-names = "mclk";
> > > +            vdd-supply = <&reg_camera_pwr_en>; /* 1.8v */
> > > +            rst-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> > > +
> > > +            port {
> > > +                camera_out: endpoint {
> > > +                    remote-endpoint = <&csi1_ep1>;
> > > +                    data-lanes = <1 2>;
> > > +                };
> > > +            };
> > > +        };
> > > +    };
> > > +
> > > +...
> 
> -- 
> Regards,
> 
> Laurent Pinchart

-- 
Sakari Ailus

  parent reply	other threads:[~2021-06-02 14:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-28  8:13 [PATCH v2 0/5] Add support for the Hynix Hi-846 camera Martin Kepplinger
2021-05-28  8:13 ` [PATCH v2 1/5] dt-bindings: vendor-prefixes: Add SK Hynix Inc Martin Kepplinger
2021-05-28  8:13 ` [PATCH v2 2/5] dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor Martin Kepplinger
2021-05-28  8:35   ` Laurent Pinchart
2021-06-02 13:52     ` Sakari Ailus
2021-06-02 13:51   ` Sakari Ailus
2021-06-02 14:05     ` Laurent Pinchart
2021-06-02 14:12       ` Martin Kepplinger
2021-06-02 14:37       ` Sakari Ailus [this message]
2021-05-28  8:13 ` [PATCH v2 3/5] media: i2c: add driver for the SK Hynix Hi-846 8M pixel camera Martin Kepplinger
2021-05-28 18:20   ` kernel test robot
2021-05-28 19:08   ` kernel test robot
2021-06-02 14:36   ` Sakari Ailus
2021-05-28  8:13 ` [PATCH v2 4/5] arm64: defconfig: enable VIDEO_HI846 Martin Kepplinger
2021-05-28  8:13 ` [PATCH v2 5/5] Documentation: i2c-cardlist: add the Hynix hi846 sensor Martin Kepplinger
2021-05-30 21:23 ` [PATCH v2 0/5] Add support for the Hynix Hi-846 camera Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210602143726.GZ3@valkosipuli.retiisi.eu \
    --to=sakari.ailus@iki.fi \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@puri.sm \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    --cc=mchehab@kernel.org \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=robh@kernel.org \
    --cc=shawnx.tu@intel.com \
    --subject='Re: [PATCH v2 2/5] dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).