From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10612C47097 for ; Wed, 2 Jun 2021 20:06:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D73BE613B8 for ; Wed, 2 Jun 2021 20:06:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229813AbhFBUIL (ORCPT ); Wed, 2 Jun 2021 16:08:11 -0400 Received: from mail-ot1-f44.google.com ([209.85.210.44]:41937 "EHLO mail-ot1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbhFBUII (ORCPT ); Wed, 2 Jun 2021 16:08:08 -0400 Received: by mail-ot1-f44.google.com with SMTP id 36-20020a9d0ba70000b02902e0a0a8fe36so3574392oth.8; Wed, 02 Jun 2021 13:06:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Eqg/NhAI7hbUorU0sneYRdLeG0QUON8FK2Nid9hN1UY=; b=VJSmbYP3HrQKqbOzjw3tpJjFjGkz61G7E0Wuyulqx7ljopCAyYQ1TkDsHiApCi2M5n MYI57o9brvzNrMFGgsXjy58Ff4eB57diI5/D3B9m2lexq9ixRxZzqkiXo15OyK3lZLka Dqy8445nnJqOBZoAmoovQ9qtRq3McP/J7J0j/y3ct9FNrlPocnVIwvC8EqHkqYA7DB8l 2aWxwia4N+wMkCPbJXgYF9gtpomNc5dHcXUtiNUb9z2uVKOHhtCjwOixJMo5yRpR7iKQ Z3aQt/pd/rbTZWfXuPXXINdCu80dmK6ar7LWcSs7l3GF98DweiYpLmyz68qgW6VsBYHV tnwA== X-Gm-Message-State: AOAM5314IrOlteVIYirBQpnNAbfiG78TzugS+N+DEyRcJGuPuV66nsIw slaRP9+w/fULxl5Hbpwzuw== X-Google-Smtp-Source: ABdhPJwOOhWiTlBUVMkgdreVunVQq9Th2V0p/jeTk68tZ2BCDbzX7OWLgT1+YDeOhvnir4cNa8WV0A== X-Received: by 2002:a9d:6194:: with SMTP id g20mr4537073otk.8.1622664371257; Wed, 02 Jun 2021 13:06:11 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id i9sm189166oog.17.2021.06.02.13.06.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 13:06:10 -0700 (PDT) Received: (nullmailer pid 3900234 invoked by uid 1000); Wed, 02 Jun 2021 20:06:09 -0000 Date: Wed, 2 Jun 2021 15:06:09 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: Lee Jones , Rob Herring , Chanwoo Choi , Alessandro Zummo , Mark Brown , linux-samsung-soc@vger.kernel.org, Liam Girdwood , Sebastian Reichel , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Bartlomiej Zolnierkiewicz , devicetree@vger.kernel.org, Iskren Chernev , Krzysztof Kozlowski , Alexandre Belloni , Stephen Boyd , Michael Turquette , linux-rtc@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 7/7] power: supply: max17040: Do not enforce (incorrect) interrupt trigger type Message-ID: <20210602200609.GA3900200@robh.at.kernel.org> References: <20210526172036.183223-1-krzysztof.kozlowski@canonical.com> <20210526172036.183223-8-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210526172036.183223-8-krzysztof.kozlowski@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 May 2021 13:20:36 -0400, Krzysztof Kozlowski wrote: > From: Krzysztof Kozlowski > > Interrupt line can be configured on different hardware in different way, > even inverted. Therefore driver should not enforce specific trigger > type - edge falling - but instead rely on Devicetree to configure it. > > The Maxim 14577/77836 datasheets describe the interrupt line as active > low with a requirement of acknowledge from the CPU therefore the edge > falling is not correct. > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Iskren Chernev > > --- > > Changes since v1: > 1. Remove the 'flags' variable. > 2. Added ack. > 3. Rebase - the bindings were converted to dtschema. > --- > .../devicetree/bindings/power/supply/maxim,max17040.yaml | 2 +- > drivers/power/supply/max17040_battery.c | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) > Acked-by: Rob Herring