From: Rob Herring <robh@kernel.org>
To: Jamin Lin <jamin_lin@aspeedtech.com>
Cc: Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Brendan Higgins <brendanhiggins@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Rayn Chen <rayn_chen@aspeedtech.com>,
"open list:I2C SUBSYSTEM HOST DRIVERS"
<linux-i2c@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-aspeed@lists.ozlabs.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/ASPEED I2C DRIVER" <openbmc@lists.ozlabs.org>,
ryan_chen@aspeedtech.com, chin-ting_kuo@aspeedtech.com,
troy_lee@aspeedtech.com, steven_lee@aspeedtech.com
Subject: Re: [PATCH v2 1/1] dt-bindings: aspeed-i2c: Convert txt to yaml format
Date: Wed, 2 Jun 2021 15:17:20 -0500 [thread overview]
Message-ID: <20210602201720.GA3910963@robh.at.kernel.org> (raw)
In-Reply-To: <20210527102512.20684-2-jamin_lin@aspeedtech.com>
On Thu, May 27, 2021 at 06:25:05PM +0800, Jamin Lin wrote:
> Convert aspeed i2c to yaml.
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
> .../devicetree/bindings/i2c/aspeed,i2c.yaml | 86 +++++++++++++++++++
> .../devicetree/bindings/i2c/i2c-aspeed.txt | 49 -----------
> 2 files changed, 86 insertions(+), 49 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-aspeed.txt
>
> diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> new file mode 100644
> index 000000000000..1f7064d77708
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> @@ -0,0 +1,86 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/aspeed,i2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ASPEED I2C on the AST24XX, AST25XX, and AST26XX SoCs Device Tree Bindings
> +
> +maintainers:
> + - Rayn Chen <rayn_chen@aspeedtech.com>
> +
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - aspeed,ast2400-i2c-bus
> + - aspeed,ast2500-i2c-bus
> + - aspeed,ast2600-i2c-bus
> +
> + "#size-cells":
> + const: 0
> +
> + "#address-cells":
> + const: 1
These 2 are covered by i2c-controller.yaml.
> +
> + reg:
> + minItems: 1
> + maxItems: 2
> + items:
> + - description: address offset and range of bus
> + - description: address offset and range of bus buffer
> +
> + interrupts:
> + maxItems: 1
> + description: interrupt number
Drop. Not a useful description.
> +
> + clocks:
> + maxItems: 1
> + description:
> + root clock of bus, should reference the APB
> + clock in the second cell
> +
> + reset:
resets
> + maxItems: 1
> + description: phandle to reset controller with the reset number in
> + the second cell
No need to describe the format of 'resets'.
> +
> + bus-frequency:
> + minimum: 500
> + maximum: 4000000
> + default: 100000
> + description: frequency of the bus clock in Hz defaults to 100 kHz when not
> + specified
> +
> + multi-master:
> + type: boolean
> + description:
> + states that there is another master active on this bus
> +
> +required:
> + - reg
> + - compatible
> + - clocks
> + - resets
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/aspeed-clock.h>
> + i2c0: i2c-bus@40 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #interrupt-cells = <1>;
> + reg = <0x40 0x40>;
> + compatible = "aspeed,ast2500-i2c-bus";
Convention is compatible first in the list of properties.
> + clocks = <&syscon ASPEED_CLK_APB>;
> + resets = <&syscon ASPEED_RESET_I2C>;
> + bus-frequency = <100000>;
> + interrupts = <0>;
> + interrupt-parent = <&i2c_ic>;
> + status = "disabled";
Don't show status in examples especially when disabling disables some
validation...
> + /* Does not need pinctrl properties */
> + };
next prev parent reply other threads:[~2021-06-02 20:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 10:25 [PATCH v2 0/1] dt-bindings-aspeed-i2 Convert to yaml format Jamin Lin
2021-05-27 10:25 ` [PATCH v2 1/1] dt-bindings: aspeed-i2c: Convert txt " Jamin Lin
2021-05-27 23:20 ` Andrew Jeffery
2021-05-28 1:44 ` Jamin Lin
2021-06-02 20:17 ` Rob Herring [this message]
2021-06-03 1:46 ` Jamin Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210602201720.GA3910963@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=chin-ting_kuo@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=rayn_chen@aspeedtech.com \
--cc=ryan_chen@aspeedtech.com \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).