From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA0BC47093 for ; Wed, 2 Jun 2021 21:54:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 343F06108D for ; Wed, 2 Jun 2021 21:54:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229767AbhFBV4A (ORCPT ); Wed, 2 Jun 2021 17:56:00 -0400 Received: from mail-pf1-f181.google.com ([209.85.210.181]:34457 "EHLO mail-pf1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229744AbhFBVz6 (ORCPT ); Wed, 2 Jun 2021 17:55:58 -0400 Received: by mail-pf1-f181.google.com with SMTP id g6so3297649pfq.1 for ; Wed, 02 Jun 2021 14:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=35KIHc2zbuqTDDmHxLiGEjjkMvfweMiA7dOZFvgi+4Q=; b=LjLCPWyUJCv/nwUzKFfEIhyVhVfkxZ26x4S6/dHjpZfmu4UWHdiIykV7QdhTgyDSNk EhJsuQdjywMyc0patC9/YhnK4GAEKwXcWBH1k9VcGDPLLnGjo6s3g0NA4yxRRM2jwLtJ aOdBLSMDVdqFcVTlHqXB8ayK55NwWyV5sFYOg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=35KIHc2zbuqTDDmHxLiGEjjkMvfweMiA7dOZFvgi+4Q=; b=ZfG76AIbm1h4X9WoGWhDM6hH1Xr3bjWLQSk0WeoX44sJy2pQ2DC0UqocoGSaDoz/ry vIsJ3BejObdaPTRe1A8o1hU2vYJCkrj5cBG/xdmk6vIOJch7otauaaqlUOXe4vsL5wYi ei6JX6HeugjpbeRkhGSZNJFABTwN/tHNU10z84hfh/pkba7BXTJ9nvb3BEUo5MogEijT HcWo7lalrY+fnqyFjehopvLTWaZRcE6gp1x0XoRauE6mCtCl/Zk1+M9j62DytdQI33cF 6aAVbmS9UFtm/EQg6Z2j8LgctrMD5dLn7kivVouoxHABc0vDKN0MKHr7iHNaDuPU0nun +diw== X-Gm-Message-State: AOAM530htYTDVFeSiBBxR/CrT6vuVEnwQBFde4h8T0IOZ3pfFjgS6BCL 5Yzu0J0tPucyTMykxhIzXloEnQ== X-Google-Smtp-Source: ABdhPJyxg3ClKV30rkuhRaEjtEXoFLZP5PUk5uHwm06Hhq5bZhf8yYnj5RfUFCfEaRDEHlS+nL22Aw== X-Received: by 2002:a62:7fc5:0:b029:2de:5813:8890 with SMTP id a188-20020a627fc50000b02902de58138890mr28955694pfd.60.1622670780709; Wed, 02 Jun 2021 14:53:00 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i2sm364203pjj.25.2021.06.02.14.52.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 14:52:59 -0700 (PDT) From: Kees Cook To: Dave Airlie Cc: Kees Cook , Arnd Bergmann , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , kernel test robot , Sai Prakash Ranjan , Emma Anholt , Rob Clark , Sean Paul , Sharat Masetty , Rob Herring , Linus Walleij , Sam Ravnborg , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: [PATCH 1/3] drm: Avoid circular dependencies for CONFIG_FB Date: Wed, 2 Jun 2021 14:52:50 -0700 Message-Id: <20210602215252.695994-2-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210602215252.695994-1-keescook@chromium.org> References: <20210602215252.695994-1-keescook@chromium.org> MIME-Version: 1.0 X-Patch-Hashes: v=1; h=sha256; g=331c9dbab9265663d4598c7d5fe5739206ff6d5a; i=Fc5wke0Q0f+i/yxn94DGR+5HIU9duCLMgabBT2xqE4s=; m=wFfctFfoMi2zK6PlZHUypYp3tGHtf9WefM0kh+Zb8ng=; p=2mlWRMfcN4+QsvDCUI3dA5+oKnCQumRrgTAwchW8Ges= X-Patch-Sig: m=pgp; i=keescook@chromium.org; s=0x0x8972F4DFDC6DC026; b=iQIzBAABCgAdFiEEpcP2jyKd1g9yPm4TiXL039xtwCYFAmC3/bMACgkQiXL039xtwCbhEg/+Imd 0I18ddKDJ9AiCRaG4Zm1BLowuBeI2IKKfqbSeXmJVztPyaBSLkLUiCIzM3MraBgl3w6HXFulytfW2 nep/TIf/0nf4qsDdCuOEnaBb8hWd04D8gGmQfqmrvTcIXv1RFcvb0io3fZbESdDpGrEKC5Cathvfg mKqvE4wkTDCtAiGjlK3mb5httl3x0WSV9StwVD26pfFgqDnVNfpxzbqVYfsEfDslKlpQaqLpqoOhq WtU4Dct+QHtYkk4kTSZ+xZIAL0POqSf/2kIYYII/N4dlF5sc9SIdUjsfUEO+OlYboBiabk1sGEyzN qjh6zeiMPt5Gp8cH57QRixWB/UIOhDwgKq5jVkMC5Qev4r93gj19EjjHKEVThWtrJW1uXmfgfgRmS 4pO5aXWdh6U6EdFrG3/h/hfqHxxBc7zBjUPkli5zHNEvLYVodijf/wWXHAIZ+V1LAk2811KyASnSc fHv6akvRK//nNX4CYCb+suSdUD79IzDdK0UtBj4f9k2+aZZZddlhraBwEbSRNUPjGUnYJ20xGI2Hu HV7uZiw7qFYjJFzyvxzgQEZNLcYb8VMYigUHPc+8XdMiICDvqC3PH/+ZQBT0NvAJrUb8Af1FZJa4d EQE+6ZRFjC0Hq5YzPHOoIpnJEPHz6KwlwcRmXWI/3q6u1VHLg7D5d8J0B8fzkQjM= Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When cleaning up other drm config dependencies, it is too easy to create larger problems. Instead, mark CONFIG_FB as a "depends": drivers/gpu/drm/Kconfig:74:error: recursive dependency detected! Suggested-by: Arnd Bergmann Link: https://lore.kernel.org/lkml/CAK8P3a3jUQs6c5tESSNMbqfuymewj9FhqRizyHcfOXf8Rgy-nA@mail.gmail.com/ Signed-off-by: Kees Cook --- drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 3c16bd1afd87..90891284ccec 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -83,7 +83,7 @@ config DRM_KMS_HELPER config DRM_KMS_FB_HELPER bool depends on DRM_KMS_HELPER - select FB + depends on FB select FRAMEBUFFER_CONSOLE if !EXPERT select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE select FB_SYS_FOPS -- 2.25.1