From: Michael Tretter <m.tretter@pengutronix.de>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: linuxarm@huawei.com, mauro.chehab@huawei.com,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 3/6] media: allegro-dvt: avoid EN DASH char
Date: Thu, 3 Jun 2021 08:33:50 +0200 [thread overview]
Message-ID: <20210603063350.GB12967@pengutronix.de> (raw)
In-Reply-To: <94f20b3817342ace2ac06057150b73996874c43f.1622646256.git.mchehab+huawei@kernel.org>
On Wed, 02 Jun 2021 17:05:20 +0200, Mauro Carvalho Chehab wrote:
> While there's nothing wrong with EN DASH on C code, this probably
> came from some cut-and paste from an ITU-T table.
> It sounds better to just an HYPHEN here.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> drivers/media/platform/allegro-dvt/nal-h264.c | 2 +-
> drivers/media/platform/allegro-dvt/nal-hevc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/allegro-dvt/nal-h264.c b/drivers/media/platform/allegro-dvt/nal-h264.c
> index 94dd9266d850..a02095eb3fcf 100644
> --- a/drivers/media/platform/allegro-dvt/nal-h264.c
> +++ b/drivers/media/platform/allegro-dvt/nal-h264.c
> @@ -25,7 +25,7 @@
> #include "nal-rbsp.h"
>
> /*
> - * See Rec. ITU-T H.264 (04/2017) Table 7-1 – NAL unit type codes, syntax
> + * See Rec. ITU-T H.264 (04/2017) Table 7-1 -- NAL unit type codes, syntax
This should be a single instead of a double hyphen.
With that fixed
Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
Michael
> * element categories, and NAL unit type classes
> */
> enum nal_unit_type {
> diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.c b/drivers/media/platform/allegro-dvt/nal-hevc.c
> index 5db540c69bfe..15a352e45831 100644
> --- a/drivers/media/platform/allegro-dvt/nal-hevc.c
> +++ b/drivers/media/platform/allegro-dvt/nal-hevc.c
> @@ -25,7 +25,7 @@
> #include "nal-rbsp.h"
>
> /*
> - * See Rec. ITU-T H.265 (02/2018) Table 7-1 – NAL unit type codes and NAL unit
> + * See Rec. ITU-T H.265 (02/2018) Table 7-1 - NAL unit type codes and NAL unit
> * type classes
> */
> enum nal_unit_type {
> --
> 2.31.1
>
>
next prev parent reply other threads:[~2021-06-03 6:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 15:05 [PATCH 0/6] media: replace some chars on C files Mauro Carvalho Chehab
2021-06-02 15:05 ` [PATCH 1/6] media: gspca: ov519: replace RIGHT SINGLE QUOTATION MARK Mauro Carvalho Chehab
2021-06-02 15:05 ` [PATCH 2/6] media: rtl28xxu: replace a NO-BREAK SPACE character Mauro Carvalho Chehab
2021-06-02 15:05 ` [PATCH 3/6] media: allegro-dvt: avoid EN DASH char Mauro Carvalho Chehab
2021-06-03 6:33 ` Michael Tretter [this message]
2021-06-02 15:05 ` [PATCH 4/6] media: saa7134: drop a NO-BREAK SPACE Mauro Carvalho Chehab
2021-06-02 15:05 ` [PATCH 5/6] media: rc: ite-cir: replace some an EN DASH Mauro Carvalho Chehab
2021-06-02 15:05 ` [PATCH 6/6] media: pci: tw5864: avoid usage of some characters Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603063350.GB12967@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mauro.chehab@huawei.com \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).