linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Daniel Scally <djrscally@gmail.com>,
	"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Maximilian Luz <luzmaximilian@gmail.com>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org
Cc: kbuild-all@lists.01.org
Subject: Re: [PATCH v5 5/6] platform/x86: Add intel_skl_int3472 driver
Date: Fri, 4 Jun 2021 09:31:01 +0800	[thread overview]
Message-ID: <202106040951.xabRueHQ-lkp@intel.com> (raw)
In-Reply-To: <20210603224007.120560-6-djrscally@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3486 bytes --]

Hi Daniel,

I love your patch! Perhaps something to improve:

[auto build test WARNING on pm/linux-next]
[also build test WARNING on lee-mfd/for-mfd-next linus/master v5.13-rc4 next-20210603]
[cannot apply to gpio/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Daniel-Scally/Introduce-intel_skl_int3472-module/20210604-064345
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/3edcad8c200f211063a35d125e9fd350a2efeb40
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Daniel-Scally/Introduce-intel_skl_int3472-module/20210604-064345
        git checkout 3edcad8c200f211063a35d125e9fd350a2efeb40
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/platform/x86/intel-int3472/intel_skl_int3472_tps68470.c:76:5: warning: no previous prototype for 'skl_int3472_tps68470_calc_type' [-Wmissing-prototypes]
      76 | int skl_int3472_tps68470_calc_type(struct acpi_device *adev)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/skl_int3472_tps68470_calc_type +76 drivers/platform/x86/intel-int3472/intel_skl_int3472_tps68470.c

    52	
    53	/** skl_int3472_tps68470_calc_type: Check what platform a device is designed for
    54	 * @adev: A pointer to a &struct acpi_device
    55	 *
    56	 * Check CLDB buffer against the PMIC's adev. If present, then we check
    57	 * the value of control_logic_type field and follow one of the
    58	 * following scenarios:
    59	 *
    60	 *	1. No CLDB - likely ACPI tables designed for ChromeOS. We
    61	 *	create platform devices for the GPIOs and OpRegion drivers.
    62	 *
    63	 *	2. CLDB, with control_logic_type = 2 - probably ACPI tables
    64	 *	made for Windows 2-in-1 platforms. Register pdevs for GPIO,
    65	 *	Clock and Regulator drivers to bind to.
    66	 *
    67	 *	3. Any other value in control_logic_type, we should never have
    68	 *	gotten to this point; fail probe and return.
    69	 *
    70	 * Return:
    71	 * * 1		Device intended for ChromeOS
    72	 * * 2		Device intended for Windows
    73	 * * -EINVAL	Where @adev has an object named CLDB but it does not conform to
    74	 *		our expectations
    75	 */
  > 76	int skl_int3472_tps68470_calc_type(struct acpi_device *adev)
    77	{
    78		struct int3472_cldb cldb = { 0 };
    79		int ret;
    80	
    81		/*
    82		 * A CLDB buffer that exists, but which does not match our expectations
    83		 * should trigger an error so we don't blindly continue.
    84		 */
    85		ret = skl_int3472_fill_cldb(adev, &cldb);
    86		if (ret && ret != -ENODEV)
    87			return ret;
    88	
    89		if (ret)
    90			return DESIGNED_FOR_CHROMEOS;
    91	
    92		if (cldb.control_logic_type != 2)
    93			return -EINVAL;
    94	
    95		return DESIGNED_FOR_WINDOWS;
    96	}
    97	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65661 bytes --]

  reply	other threads:[~2021-06-04  1:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 22:40 [PATCH v5 0/6] Introduce intel_skl_int3472 module Daniel Scally
2021-06-03 22:40 ` [PATCH v5 1/6] ACPI: scan: Extend acpi_walk_dep_device_list() Daniel Scally
2021-06-03 22:40 ` [PATCH v5 2/6] ACPI: scan: Add function to fetch dependent of acpi device Daniel Scally
2021-06-07 14:52   ` Rafael J. Wysocki
2021-06-03 22:40 ` [PATCH v5 3/6] gpiolib: acpi: Export acpi_get_gpiod() Daniel Scally
2021-06-04 12:59   ` Andy Shevchenko
2021-06-04 14:09     ` Daniel Scally
2021-06-03 22:40 ` [PATCH v5 4/6] gpiolib: acpi: Add acpi_gpio_get_io_resource() Daniel Scally
2021-06-04 13:01   ` Andy Shevchenko
2021-06-04 14:09     ` Daniel Scally
2021-06-04 14:33       ` Andy Shevchenko
2021-06-04 16:54         ` Daniel Scally
2021-06-03 22:40 ` [PATCH v5 5/6] platform/x86: Add intel_skl_int3472 driver Daniel Scally
2021-06-04  1:31   ` kernel test robot [this message]
2021-06-05 23:07     ` Daniel Scally
2021-06-04  6:49   ` kernel test robot
2021-06-16 17:58   ` Hans de Goede
2021-06-16 18:08     ` Andy Shevchenko
2021-06-16 18:13       ` Hans de Goede
2021-06-16 21:42     ` Daniel Scally
2021-06-03 22:40 ` [PATCH v5 6/6] mfd: tps68470: Remove tps68470 MFD driver Daniel Scally
2021-06-17 11:14   ` Hans de Goede
2021-06-08  9:00 ` [PATCH v5 0/6] Introduce intel_skl_int3472 module Hans de Goede
2021-06-08  9:33   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202106040951.xabRueHQ-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=djrscally@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=kbuild-all@lists.01.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luzmaximilian@gmail.com \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).