From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF5B3C07E94 for ; Fri, 4 Jun 2021 12:22:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A807C61412 for ; Fri, 4 Jun 2021 12:22:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230142AbhFDMYm (ORCPT ); Fri, 4 Jun 2021 08:24:42 -0400 Received: from elvis.franken.de ([193.175.24.41]:36878 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230025AbhFDMYl (ORCPT ); Fri, 4 Jun 2021 08:24:41 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lp8qj-00060t-00; Fri, 04 Jun 2021 14:22:53 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 4042BC1B8C; Fri, 4 Jun 2021 14:22:23 +0200 (CEST) Date: Fri, 4 Jun 2021 14:22:23 +0200 From: Thomas Bogendoerfer To: Linus Walleij , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v5 1/2] gpio: Add support for IDT 79RC3243x GPIO controller Message-ID: <20210604122223.GA8940@alpha.franken.de> References: <20210514123309.134048-1-tsbogend@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210514123309.134048-1-tsbogend@alpha.franken.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 14, 2021 at 02:33:07PM +0200, Thomas Bogendoerfer wrote: > IDT 79RC3243x SoCs integrated a gpio controller, which handles up > to 32 gpios. All gpios could be used as an interrupt source. > > Signed-off-by: Thomas Bogendoerfer > --- > Changes in v5: > - use bgpio spinlock > - made interrupt controller optional > - made ngpios optional > > Changes in v4: > - added spinlock to serialize access to irq registers > - reworked checking of irq sense bits > - start with handle_bad_irq and set handle_level_irq in idt_gpio_irq_set_type > - cleaned up #includes > - use platform_get_irq > > Changes in v3: > - changed compatible string to idt,32434-gpio > - registers now start with gpio direction register and leaves > out alternate function register for pinmux/pinctrl driver > > Changes in v2: > - made driver buildable as module > - use for_each_set_bit() in irq dispatch handler > - use gpiochip_get_data instead of own container_of helper > - use module_platform_driver() instead of arch_initcall > - don't default y for Mikrotik RB532 > > drivers/gpio/Kconfig | 12 ++ > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-idt3243x.c | 206 +++++++++++++++++++++++++++++++++++ > 3 files changed, 219 insertions(+) > create mode 100644 drivers/gpio/gpio-idt3243x.c > [...] is there anything a still need to do to get this integrated for v5.14 ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]