Re: [PATCH 1/1] clk: Export clk_register_composite

From: Lee Jones <lee.jones@linaro.org>
To: Wendell Lin <wendell.lin@mediatek.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	linux-clk <linux-clk@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	ARM/Mediatek SoC support <linux-mediatek@lists.infradead.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	wsd_upstream <wsd_upstream@mediatek.com>
Subject: Re: [PATCH 1/1] clk: Export clk_register_composite
Date: Fri, 4 Jun 2021 14:23:35 +0100	[thread overview]
Message-ID: <20210604132335.GK2435141@dell> (raw)
In-Reply-To: <1622802121.26830.22.camel@mtkswgap22>

On Fri, 04 Jun 2021, Wendell Lin wrote:

> On Fri, 2021-06-04 at 09:25 +0100, Lee Jones wrote:
> > On Fri, 04 Jun 2021, Lee Jones wrote:
> > 
> > > On Thu, 03 Jun 2021, Stephen Boyd wrote:
> > > 
> > > > Quoting Lee Jones (2021-05-20 09:07:42)
> > > > > On Mon, 10 Aug 2020 at 10:36, Wendell Lin <wendell.lin@mediatek.com> wrote:
> > > > > 
> > > > >     Hi Matthias and all,
> > > > > 
> > > > >     Gentle ping on this patch.
> > > > > 
> > > > > 
> > > > > What about a not-so-gentle ping on this patch?  Grrrr... :)
> > > > > 
> > > > > FYI, this is still required by more than one source.
> > > > > 
> > > > > Please help get this out of all of the vendor trees please.
> > > > > 
> > > > 
> > > > Is there an in-kernel user?
> > > 
> > > How can there be?  It's not exported yet. :)
> > > 
> > > However there shouldn't be any barriers for vendors represented in
> > > Mainline to build their drivers as modules if they so wish.  If/when
> > > they do, this will need to be exported.
> > 
> > Wendell Lin, is this what you wish to do with the in-kernel MediaTek
> > driver?
> > 
> This is because Mediatek clock driver would be built as kernel module,
> so clk_register_composite() used should be exported, then we could use
> it. 
> 
> Please refer:
> [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support 
> https://lkml.org/lkml/2020/7/1/124
> +EXPORT_SYMBOL(mtk_clk_register_composites);
> 
> clk_register_composite() is used by Mediatek clk kernel module.
> From export symbol: mtk_clk_register_composites. 

Perfect.  Thanks for the clarification.

Anything else you need from us Stephen?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog