From: Rob Herring <robh@kernel.org>
To: Liam Beguin <liambeguin@gmail.com>
Cc: peda@axentia.se, jic23@kernel.org, lars@metafoo.de,
pmeerw@pmeerw.net, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 7/9] dt-bindings: iio: afe: add binding for temperature-sense-rtd
Date: Fri, 4 Jun 2021 16:17:02 -0500 [thread overview]
Message-ID: <20210604211702.GA3925041@robh.at.kernel.org> (raw)
In-Reply-To: <20210530005917.20953-8-liambeguin@gmail.com>
On Sat, May 29, 2021 at 08:59:15PM -0400, Liam Beguin wrote:
> From: Liam Beguin <lvb@xiphos.com>
>
> An ADC is often used to measure other quantities indirectly. This
> binding describe one cases, the measurement of a temperature through
> the voltage across an RTD resistor such as a PT1000.
>
> Signed-off-by: Liam Beguin <lvb@xiphos.com>
> ---
> .../iio/afe/temperature-sense-rtd.yaml | 65 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/afe/temperature-sense-rtd.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/afe/temperature-sense-rtd.yaml b/Documentation/devicetree/bindings/iio/afe/temperature-sense-rtd.yaml
> new file mode 100644
> index 000000000000..4798eda6e533
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/afe/temperature-sense-rtd.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/afe/temperature-sense-rtd.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Temperature Sense RTD
> +
> +maintainers:
> + - Liam Beguin <lvb@xiphos.com>
> +
> +description: |
> + When an io-channel measures the output voltage across an RTD such as a
What's an RTD? Not defined anywhere here.
> + PT1000, the interesting measurement is almost always the corresponding
> + temperature, not the voltage output. This binding describes such a circuit.
> +
> +properties:
> + compatible:
> + const: temperature-sense-rtd
> +
> + io-channels:
> + maxItems: 1
> + description: |
> + Channel node of a voltage io-channel.
> +
> + '#io-channel-cells':
> + const: 1
Doesn't this belong in the provider?
> +
> + excitation-current-microamp:
> + description: The current fed through the RTD sensor.
> +
> + alpha-micro-ohms-per-ohm-celsius:
> + description: |
> + Linear approximation of the resistance versus temperature relationship
> + between 0 and 100 degrees Celsius.
> +
> + Pure platinum has an alpha of 3925. Industry standards such as IEC60751
> + and ASTM E-1137 specify an alpha of 3850.
Is there a max and min value?
> +
> + r-naught-ohms:
> + description: |
> + Resistance of the sensor at 0 degrees Celsius.
> + Common values are 100 for PT100 and 1000 for PT1000.
max or min?
> +
> +additionalProperties: false
blank line here.
> +required:
> + - compatible
> + - io-channels
> + - excitation-current-microamp
> + - alpha-micro-ohms-per-ohm-celsius
> + - r-naught-ohms
> +
> +examples:
> + - |
> + pt1000_1: iio-rescale0 {
> + compatible = "temperature-sense-rtd";
> + #io-channel-cells = <1>;
> + io-channels = <&temp_adc1 0>;
> +
> + excitation-current-microamp = <1000>;
> + alpha-micro-ohms-per-ohm-celsius = <3908>;
> + r-naught-ohms = <1000>;
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d3ab0ccc34ab..a7279af85adb 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8721,6 +8721,7 @@ L: linux-iio@vger.kernel.org
> S: Maintained
> F: Documentation/devicetree/bindings/iio/afe/current-sense-amplifier.yaml
> F: Documentation/devicetree/bindings/iio/afe/current-sense-shunt.yaml
> +F: Documentation/devicetree/bindings/iio/afe/temperature-sense-rtd.yaml
> F: Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml
> F: drivers/iio/afe/iio-rescale.c
>
> --
> 2.30.1.489.g328c10930387
next prev parent reply other threads:[~2021-06-04 21:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 0:59 [PATCH v1 0/9] iio: afe: add temperature rescaling support Liam Beguin
2021-05-30 0:59 ` [PATCH v1 1/9] iio: inkern: always apply scale requested by consumer Liam Beguin
2021-05-31 13:39 ` Peter Rosin
2021-05-30 0:59 ` [PATCH v1 2/9] iio: inkern: error out on unsupported offset type Liam Beguin
2021-05-31 9:45 ` Peter Rosin
2021-05-31 13:31 ` Liam Beguin
2021-05-30 0:59 ` [PATCH v1 3/9] iio: afe: rescale: use core to get processed value Liam Beguin
2021-05-31 7:09 ` Peter Rosin
2021-05-31 13:23 ` Liam Beguin
2021-06-01 16:22 ` Jonathan Cameron
2021-05-30 0:59 ` [PATCH v1 4/9] iio: afe: rescale: add offset support Liam Beguin
2021-05-31 8:52 ` Peter Rosin
2021-05-31 13:36 ` Liam Beguin
2021-05-31 14:08 ` Peter Rosin
2021-05-31 14:51 ` Liam Beguin
2021-05-31 16:25 ` Peter Rosin
2021-05-31 17:42 ` Liam Beguin
2021-06-01 16:31 ` Jonathan Cameron
2021-05-30 0:59 ` [PATCH v1 5/9] iio: afe: rescale: add support for temperature sensors Liam Beguin
2021-06-01 16:34 ` Jonathan Cameron
2021-05-30 0:59 ` [PATCH v1 6/9] dt-bindings: iio: afe: update MAINTAINERS file Liam Beguin
2021-05-31 7:57 ` Peter Rosin
2021-05-30 0:59 ` [PATCH v1 7/9] dt-bindings: iio: afe: add binding for temperature-sense-rtd Liam Beguin
2021-06-01 16:43 ` Jonathan Cameron
2021-06-04 21:17 ` Rob Herring [this message]
2021-06-05 14:58 ` Jonathan Cameron
2021-05-30 0:59 ` [PATCH v1 8/9] dt-bindings: iio: afe: add binding for temperature-sense-current Liam Beguin
2021-05-31 7:28 ` Peter Rosin
2021-05-31 8:58 ` Peter Rosin
2021-05-31 13:41 ` Liam Beguin
2021-06-01 16:47 ` Jonathan Cameron
2021-06-04 21:21 ` Rob Herring
2021-05-30 0:59 ` [PATCH v1 9/9] dt-bindings: iio: afe: add binding for temperature-sense-amplifier Liam Beguin
2021-05-31 7:32 ` Peter Rosin
2021-05-31 14:03 ` Liam Beguin
2021-06-01 16:02 ` Jonathan Cameron
2021-06-01 16:07 ` Jonathan Cameron
2021-06-01 15:59 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210604211702.GA3925041@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).