From: Jeremy Szu <jeremy.szu@canonical.com>
To: tiwai@suse.com
Cc: Jeremy Szu <jeremy.szu@canonical.com>,
Jaroslav Kysela <perex@perex.cz>,
Kailang Yang <kailang@realtek.com>,
Hui Wang <hui.wang@canonical.com>,
Jian-Hong Pan <jhp@endlessos.org>,
Chris Chiu <chris.chiu@canonical.com>,
Huacai Chen <chenhuacai@kernel.org>,
alsa-devel@alsa-project.org (moderated list:SOUND),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 2/3] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP EliteBook x360 1040 G8
Date: Sat, 5 Jun 2021 16:25:37 +0800 [thread overview]
Message-ID: <20210605082539.41797-2-jeremy.szu@canonical.com> (raw)
In-Reply-To: <20210605082539.41797-1-jeremy.szu@canonical.com>
The HP EliteBook x360 1040 G8 using ALC285 codec which using 0x04 to control
mute LED and 0x01 to control micmute LED.
In the other hand, there is no output from right channel of speaker.
Therefore, add a quirk to make it works.
Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 9f65171a902d..11324163ebe1 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8311,6 +8311,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x86c7, "HP Envy AiO 32", ALC274_FIXUP_HP_ENVY_GPIO),
SND_PCI_QUIRK(0x103c, 0x8716, "HP Elite Dragonfly G2 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
+ SND_PCI_QUIRK(0x103c, 0x8720, "HP EliteBook x360 1040 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8729, "HP", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8730, "HP ProBook 445 G7", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
--
2.31.1
next prev parent reply other threads:[~2021-06-05 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 8:25 [PATCH 1/3] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Elite Dragonfly G2 Jeremy Szu
2021-06-05 8:25 ` Jeremy Szu [this message]
2021-06-05 12:52 ` [PATCH 2/3] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP EliteBook x360 1040 G8 Takashi Iwai
2021-06-05 8:25 ` [PATCH 3/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 840 Aero G8 Jeremy Szu
2021-06-05 12:52 ` Takashi Iwai
2021-06-05 12:52 ` [PATCH 1/3] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Elite Dragonfly G2 Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210605082539.41797-2-jeremy.szu@canonical.com \
--to=jeremy.szu@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=chenhuacai@kernel.org \
--cc=chris.chiu@canonical.com \
--cc=hui.wang@canonical.com \
--cc=jhp@endlessos.org \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).