From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB76BC47082 for ; Sat, 5 Jun 2021 10:25:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B3A061248 for ; Sat, 5 Jun 2021 10:25:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230019AbhFEK1m (ORCPT ); Sat, 5 Jun 2021 06:27:42 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:43578 "EHLO mail-wr1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229902AbhFEK1k (ORCPT ); Sat, 5 Jun 2021 06:27:40 -0400 Received: by mail-wr1-f43.google.com with SMTP id u7so6296873wrs.10; Sat, 05 Jun 2021 03:25:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m969ISjz0Qg2RicSIh/DLDKZX7B7gGF5mGcynT3qU5g=; b=gSTQ2+tued6UiImWuu//oBlJfjpt/gwxvwg29XwT4DnYnd8egzGn/L0o2ogOHSgA6d rHBeSymp/nYKxg+oWHFjfFsLqyG42L42QV44U0Fksyf4Cm2MWpuOaSKivHTKx8y4STZ3 ofZdcOjBjR3hFFiqnQX4kZtjsmUrDCJaF8+yijmZz9b7bmuIakoHxI564DITRTS2a9Xv Bc7RrMofn24GuhzVvsF352dyD4JipymAreTUkotBQkS9XBCwyLIyelkc4WakHggRuwWm nNaabpWr4/vBxVjYaV5t8RPzXoHEDGP1JPRxXQTE2kxuzC2uSpcBcGbQMXvZN44S29d0 luxQ== X-Gm-Message-State: AOAM53297uQpBZUQGmdj1B+AaKbcY1FnYun40G0w8dUQjgUb8jmYInP7 WsIc5NXOgIGAmNx5WEeQHZg= X-Google-Smtp-Source: ABdhPJyd9jZ2BL1pEkcDkHDEA9rfDfI2xuCJiemXtQRM4Pul5Z0tJojgoUhXxbGqPt1WZB4KlOCO+Q== X-Received: by 2002:a05:6000:2a3:: with SMTP id l3mr8155566wry.395.1622888735842; Sat, 05 Jun 2021 03:25:35 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id p187sm8242731wmp.28.2021.06.05.03.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Jun 2021 03:25:35 -0700 (PDT) Date: Sat, 5 Jun 2021 10:25:33 +0000 From: Wei Liu To: Sunil Muthuswamy Cc: Michael Kelley , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hyperv@vger.kernel.org" Subject: Re: [PATCH 1/1] Drivers: hv: Move Hyper-V extended capability check to arch neutral code Message-ID: <20210605102533.uzvd4l7el2afes5i@liuwe-devbox-debian-v2> References: <1622669804-2016-1-git-send-email-mikelley@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 04, 2021 at 12:14:09AM +0000, Sunil Muthuswamy wrote: > > The extended capability query code is currently under arch/x86, but it > > is architecture neutral, and is used by arch neutral code in the Hyper-V > > balloon driver. Hence the balloon driver fails to build on other > > architectures. > > > > Fix by moving the ext cap code out from arch/x86. Because it is also > > called from built-in architecture specific code, it can't be in a module, > > so the Makefile treats as built-in even when CONFIG_HYPERV is "m". Also > > drivers/Makefile is tweaked because this is the first occurrence of a > > Hyper-V file that is built-in even when CONFIG_HYPERV is "m". > > > > While here, update the hypercall status check to use the new helper > > function instead of open coding. No functional change. > > > > Thanks for taking care of this, Michael. > > Reviewed-by: Sunil Muthuswamy Applied to hyperv-next. Thanks.