From: Guenter Roeck <linux@roeck-us.net>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Jean Delvare <jdelvare@suse.com>,
Madhava Reddy Siddareddygari <msiddare@cisco.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: (pmbus_core) Check adapter PEC support
Date: Sun, 6 Jun 2021 05:50:12 -0700 [thread overview]
Message-ID: <20210606125012.GA2887349@roeck-us.net> (raw)
In-Reply-To: <20210605052700.541455-1-pmenzel@molgen.mpg.de>
On Sat, Jun 05, 2021 at 07:27:02AM +0200, Paul Menzel wrote:
> From: Madhava Reddy Siddareddygari <msiddare@cisco.com>
>
> Currently, for Packet Error Checking (PEC) only the controller
> is checked for support. This causes problems on the cisco-8000
> platform where a SMBUS transaction errors are observed. This is
> because PEC has to be enabled only if both controller and
> adapter support it.
>
> Added code to check PEC capability for adapter and enable it
> only if both controller and adapter supports PEC.
>
> Signed-off-by: Madhava Reddy Siddareddygari <msiddare@cisco.com>
> [Upstream from SONiC https://github.com/Azure/sonic-linux-kernel/pull/215]
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Applied.
Thanks,
Guenter
> ---
> v2: Do not revert check introduced by commit e5befc02 (hwmon: (pmbus)
> Add a PMBUS_NO_CAPABILITY platform data flag).
>
> drivers/hwmon/pmbus/pmbus_core.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
> index bbd745178147..2fd0fec59d4f 100644
> --- a/drivers/hwmon/pmbus/pmbus_core.c
> +++ b/drivers/hwmon/pmbus/pmbus_core.c
> @@ -2214,11 +2214,15 @@ static int pmbus_init_common(struct i2c_client *client, struct pmbus_data *data,
> data->has_status_word = true;
> }
>
> - /* Enable PEC if the controller supports it */
> + /* Enable PEC if the controller and bus supports it */
> if (!(data->flags & PMBUS_NO_CAPABILITY)) {
> ret = i2c_smbus_read_byte_data(client, PMBUS_CAPABILITY);
> - if (ret >= 0 && (ret & PB_CAPABILITY_ERROR_CHECK))
> - client->flags |= I2C_CLIENT_PEC;
> + if (ret >= 0 && (ret & PB_CAPABILITY_ERROR_CHECK)) {
> + if (i2c_check_functionality(client->adapter,
> + I2C_FUNC_SMBUS_PEC)) {
> + client->flags |= I2C_CLIENT_PEC;
> + }
> + }
> }
>
> /*
next prev parent reply other threads:[~2021-06-06 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 5:27 [PATCH v2] hwmon: (pmbus_core) Check adapter PEC support Paul Menzel
2021-06-06 12:50 ` Guenter Roeck [this message]
2021-12-01 15:58 ` Paul Menzel
2021-12-01 19:57 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210606125012.GA2887349@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msiddare@cisco.com \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).