Re: [irqchip: irq/irqchip-next] irqdomain: Kill irq_domain_add_legacy_isa

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3969 bytes --]

Hi irqchip-bot,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/irq/core]
[also build test ERROR on linux/master linus/master v5.13-rc4 next-20210604]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/irqchip-bot-for-Marc-Zyngier/irqdomain-Kill-irq_domain_add_legacy_isa/20210606-204659
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 006ae1970a8cde1d3e92da69b324d12880133a13
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/7d6d9b0177b4ae53ccae4fb2c5cd387460def6ac
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review irqchip-bot-for-Marc-Zyngier/irqdomain-Kill-irq_domain_add_legacy_isa/20210606-204659
        git checkout 7d6d9b0177b4ae53ccae4fb2c5cd387460def6ac
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/powerpc/sysdev/mpic.c: In function 'mpic_find':
>> arch/powerpc/sysdev/mpic.c:605:12: error: 'NUM_ISA_INTERRUPTS' undeclared (first use in this function)
     605 |  if (irq < NUM_ISA_INTERRUPTS)
         |            ^~~~~~~~~~~~~~~~~~
   arch/powerpc/sysdev/mpic.c:605:12: note: each undeclared identifier is reported only once for each function it appears in
--
   arch/powerpc/sysdev/i8259.c: In function 'i8259_init':
>> arch/powerpc/sysdev/i8259.c:263:15: error: implicit declaration of function 'irq_domain_add_legacy_isa'; did you mean 'irq_domain_add_legacy'? [-Werror=implicit-function-declaration]
     263 |  i8259_host = irq_domain_add_legacy_isa(node, &i8259_host_ops, NULL);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~
         |               irq_domain_add_legacy
   arch/powerpc/sysdev/i8259.c:263:13: warning: assignment to 'struct irq_domain *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     263 |  i8259_host = irq_domain_add_legacy_isa(node, &i8259_host_ops, NULL);
         |             ^
   cc1: some warnings being treated as errors
--
   arch/powerpc/sysdev/xics/xics-common.c: In function 'xics_migrate_irqs_away':
>> arch/powerpc/sysdev/xics/xics-common.c:204:14: error: 'NUM_ISA_INTERRUPTS' undeclared (first use in this function)
     204 |   if (virq < NUM_ISA_INTERRUPTS)
         |              ^~~~~~~~~~~~~~~~~~
   arch/powerpc/sysdev/xics/xics-common.c:204:14: note: each undeclared identifier is reported only once for each function it appears in


vim +/NUM_ISA_INTERRUPTS +605 arch/powerpc/sysdev/mpic.c

14cf11af6cf608 Paul Mackerras         2005-09-26  601  
14cf11af6cf608 Paul Mackerras         2005-09-26  602  /* Find an mpic associated with a given linux interrupt */
d69a78d7daada1 Tony Breeds            2009-04-07  603  static struct mpic *mpic_find(unsigned int irq)
14cf11af6cf608 Paul Mackerras         2005-09-26  604  {
0ebfff1491ef85 Benjamin Herrenschmidt 2006-07-03 @605  	if (irq < NUM_ISA_INTERRUPTS)
14cf11af6cf608 Paul Mackerras         2005-09-26  606  		return NULL;
7df2457db83bc9 Olof Johansson         2007-01-28  607  
ec775d0e70eb6b Thomas Gleixner        2011-03-25  608  	return irq_get_chip_data(irq);
d69a78d7daada1 Tony Breeds            2009-04-07  609  }
7df2457db83bc9 Olof Johansson         2007-01-28  610  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 73386 bytes --]