From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23FCCC4743D for ; Mon, 7 Jun 2021 03:26:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00A8B61208 for ; Mon, 7 Jun 2021 03:26:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230258AbhFGD2A (ORCPT ); Sun, 6 Jun 2021 23:28:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230226AbhFGD16 (ORCPT ); Sun, 6 Jun 2021 23:27:58 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E01DC061766 for ; Sun, 6 Jun 2021 20:25:54 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id q25so12054508pfh.7 for ; Sun, 06 Jun 2021 20:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7Dch5XxlBwOHZRN59cFkhlYsFVftmc/hmWGUQo14o6E=; b=QO9jBNmKqibUB6BZj/WNSNhz7Mzg2TwQ0mt1QBMu1d1cloed/XBrfIbkJvEhKOkCWV 19wwQaTl1f/XblWr91QkILxdc2K0p54Nhb5pdh1AQTjdtoiV88iiEPB23Kl3V/Ufk7XU Cmyf8Hzm6tzuLW/C+6d/dq8GJd4Rqu7gWEnxyOGLSAxtIxl6o707cJ6RiX7vOheyB010 7EPKrNLB2d+Qi40OBDZHCMxOWVE/Iu383hFTldlnuGo+yHR5zvnUPYyXS3y6YNQJv32M CLpjKhcgPmYK7Ls5/6Fq9e/cuxBfJgQRvsVsmFoGfmQ0OAqshTtTFuwMMPjhECXQL1xS gUcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7Dch5XxlBwOHZRN59cFkhlYsFVftmc/hmWGUQo14o6E=; b=BtnavwuXPBX7lC9c3w5wsdc5rwwmtHXtwSpmStNYtq0uliSDX5uzmbId4bauUvKVzi DSI6/0pIJWC4UVfHSwKbzHRG/s/JdHbCpZSEK0obXDKsaQIiQaKqnnTTpM3g2Pyo8d1j jRgRtLuWWEVwHpeLPbRBYx+xN32le8REyllfYhI4BCrWDXseow6mFRQ6r9jhL7CNQtm1 ztkftvR8UIRe3NSCgIVL7CCGQG6YJycoDA0VzLiME8YO52w0NNRW5sBH6dAnTEGiwVRC WokBleIcSRSXUuvb//sTAC53fPhfWf1OcDZLK5OC2mkfhDciYRiZmza95To1ngEyZ9sV LZ0w== X-Gm-Message-State: AOAM53116PBWEH/Ea960S3OQlvBDkQjnJ1Bx03YxYag58dPEr56g318+ IGm5lAf0mqNQhO99uk516odZtg== X-Google-Smtp-Source: ABdhPJyAqA37oez/nPsCcvC/NLbSQTAZOlva3EWPvOgCRqpq4fdGRY6qdmQtjzZrSdW7oaFbyy43cg== X-Received: by 2002:a62:1b88:0:b029:1fb:d3d0:343a with SMTP id b130-20020a621b880000b02901fbd3d0343amr15003381pfb.76.1623036353895; Sun, 06 Jun 2021 20:25:53 -0700 (PDT) Received: from localhost ([136.185.169.128]) by smtp.gmail.com with ESMTPSA id g2sm2034787pfc.142.2021.06.06.20.25.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jun 2021 20:25:53 -0700 (PDT) Date: Mon, 7 Jun 2021 08:55:50 +0530 From: Viresh Kumar To: kyle.meyer@hpe.com Cc: rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, Takashi Iwai Subject: Re: [PATCH] acpi-cpufreq: Skip cleanup if initialization didn't occur Message-ID: <20210607032550.qdnl2sxnny42rtwa@vireshk-i7> References: <20210604170500.46875-1-kyle.meyer@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210604170500.46875-1-kyle.meyer@hpe.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04-06-21, 12:05, kyle.meyer@hpe.com wrote: > From: Kyle Meyer > > acpi-cpufreq is loaded without performing initialization when a cpufreq > driver exists. > > If initialization didn't occur then skip cleanup in acpi_cpufreq_exit(). > This prevents unnecessary freeing and unregistering when the module is > unloaded. > > Reported-by: Takashi Iwai > Signed-off-by: Kyle Meyer > --- > drivers/cpufreq/acpi-cpufreq.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c > index 7e7450453714..8d425f14c267 100644 > --- a/drivers/cpufreq/acpi-cpufreq.c > +++ b/drivers/cpufreq/acpi-cpufreq.c > @@ -1042,8 +1042,19 @@ static int __init acpi_cpufreq_init(void) > > static void __exit acpi_cpufreq_exit(void) > { > + const char *current_driver; > + > pr_debug("%s\n", __func__); > > + /* > + * If another cpufreq_driver was loaded, preventing acpi-cpufreq from > + * registering, there's no need to unregister it. > + */ > + current_driver = cpufreq_get_current_driver(); > + if (!current_driver || > + strncmp(current_driver, acpi_cpufreq_driver.name, strlen(acpi_cpufreq_driver.name))) > + return; > + > acpi_cpufreq_boost_exit(); > > cpufreq_unregister_driver(&acpi_cpufreq_driver); Looks like some misunderstanding here, this shouldn't happen. If initialization didn't occur, then exit shall never be called. -- viresh