From: Jon Lin <jon.lin@rock-chips.com>
To: broonie@kernel.org
Cc: jon.lin@rock-chips.com, heiko@sntech.de, robh+dt@kernel.org,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: [PATCH v6 3/6] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item
Date: Mon, 7 Jun 2021 19:18:34 +0800 [thread overview]
Message-ID: <20210607111837.31074-4-jon.lin@rock-chips.com> (raw)
In-Reply-To: <20210607111837.31074-1-jon.lin@rock-chips.com>
The error here is to calculate the width as 8 bits. In fact, 16 bits
should be considered.
Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
drivers/spi/spi-rockchip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index bbeed3ae4ee1..0887b19ef3ad 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -540,8 +540,8 @@ static int rockchip_spi_config(struct rockchip_spi *rs,
* interrupt exactly when the fifo is full doesn't seem to work,
* so we need the strict inequality here
*/
- if (xfer->len < rs->fifo_len)
- writel_relaxed(xfer->len - 1, rs->regs + ROCKCHIP_SPI_RXFTLR);
+ if ((xfer->len / rs->n_bytes) < rs->fifo_len)
+ writel_relaxed(xfer->len / rs->n_bytes - 1, rs->regs + ROCKCHIP_SPI_RXFTLR);
else
writel_relaxed(rs->fifo_len / 2 - 1, rs->regs + ROCKCHIP_SPI_RXFTLR);
--
2.17.1
next prev parent reply other threads:[~2021-06-07 11:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 11:18 [PATCH v6 0/6] Support ROCKCHIP SPI new feature Jon Lin
2021-06-07 11:18 ` [PATCH v6 1/6] dt-bindings: spi: spi-rockchip: add description for rv1126 Jon Lin
2021-06-10 16:06 ` Rob Herring
2021-06-10 19:38 ` Johan Jonker
2021-06-07 11:18 ` [PATCH v6 2/6] spi: rockchip: add compatible string " Jon Lin
2021-06-07 11:18 ` Jon Lin [this message]
2021-06-07 11:18 ` [PATCH v6 4/6] spi: rockchip: Wait for STB status in slave mode tx_xfer Jon Lin
2021-06-07 11:19 ` [PATCH v6 5/6] spi: rockchip: Support cs-gpio Jon Lin
2021-06-07 11:19 ` [PATCH v6 6/6] spi: rockchip: Support SPI_CS_HIGH Jon Lin
2021-06-15 3:26 ` [PATCH v7 0/6] Support ROCKCHIP SPI new feature Jon Lin
2021-06-15 3:26 ` [PATCH v7 1/6] dt-bindings: spi: spi-rockchip: add description for rv1126 Jon Lin
2021-06-16 15:26 ` Rob Herring
2021-06-15 3:26 ` [PATCH v7 2/6] spi: rockchip: add compatible string " Jon Lin
2021-06-15 3:26 ` [PATCH v7 3/6] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item Jon Lin
2021-06-15 3:26 ` [PATCH v7 4/6] spi: rockchip: Wait for STB status in slave mode tx_xfer Jon Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210607111837.31074-4-jon.lin@rock-chips.com \
--to=jon.lin@rock-chips.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).