From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Steen Hegelund <steen.hegelund@microchip.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Madalin Bucur <madalin.bucur@oss.nxp.com>,
Mark Einon <mark.einon@gmail.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Simon Horman <simon.horman@netronome.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Bjarni Jonasson <bjarni.jonasson@microchip.com>,
Lars Povlsen <lars.povlsen@microchip.com>
Subject: Re: [PATCH net-next v3 04/10] net: sparx5: add port module support
Date: Mon, 7 Jun 2021 14:12:31 +0100 [thread overview]
Message-ID: <20210607131231.GF22278@shell.armlinux.org.uk> (raw)
In-Reply-To: <d5ffe24ce7fbe5dd4cc0b98449b0594b086e3ba9.camel@microchip.com>
Hi,
On Mon, Jun 07, 2021 at 02:46:44PM +0200, Steen Hegelund wrote:
> Hi Russell,
>
> Thanks for your comments.
>
> On Mon, 2021-06-07 at 10:21 +0100, Russell King (Oracle) wrote:
> > It looks to me like the phylink code in your patch series is based on
> > an older version of phylink and hasn't been updated for the split PCS
> > support - you seem to be munging the PCS parts in with the MAC
> > callbacks. If so, please update to the modern way of dealing with this.
> >
> > If that isn't the case, please explain why you are not using the split
> > PCS support.
>
> I need to be able to let the user set the speed to get the link up.
>
> So far I have only been able to get the user configured speeds via the mac_ops, but if this is also
> possible via the pcs_ops, there should not anything preventing me from using these ops instead.
>
> Will the pcs_ops also support this?
I really don't understand what you're saying here, so I can't answer.
What exactly do you mean "user configured speeds" ? Please give
examples of exactly what you're wanting to do.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-06-07 13:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 8:55 [PATCH net-next v3 00/10] Adding the Sparx5 Switch Driver Steen Hegelund
2021-06-04 8:55 ` [PATCH net-next v3 01/10] dt-bindings: net: sparx5: Add sparx5-switch bindings Steen Hegelund
2021-06-04 8:55 ` [PATCH net-next v3 02/10] net: sparx5: add the basic sparx5 driver Steen Hegelund
2021-06-04 9:28 ` Philipp Zabel
2021-06-07 7:34 ` Steen Hegelund
2021-06-07 8:13 ` Philipp Zabel
2021-06-04 8:55 ` [PATCH net-next v3 03/10] net: sparx5: add hostmode with phylink support Steen Hegelund
2021-06-07 9:15 ` Russell King (Oracle)
2021-06-07 12:45 ` Steen Hegelund
2021-06-07 13:09 ` Russell King (Oracle)
2021-06-07 15:12 ` Steen Hegelund
2021-06-07 15:35 ` Russell King (Oracle)
2021-06-08 9:24 ` Steen Hegelund
2021-06-04 8:55 ` [PATCH net-next v3 04/10] net: sparx5: add port module support Steen Hegelund
2021-06-07 9:21 ` Russell King (Oracle)
2021-06-07 12:46 ` Steen Hegelund
2021-06-07 13:12 ` Russell King (Oracle) [this message]
2021-06-07 15:14 ` Steen Hegelund
2021-06-04 8:55 ` [PATCH net-next v3 05/10] net: sparx5: add mactable support Steen Hegelund
2021-06-04 8:55 ` [PATCH net-next v3 06/10] net: sparx5: add vlan support Steen Hegelund
2021-06-04 8:55 ` [PATCH net-next v3 07/10] net: sparx5: add switching support Steen Hegelund
2021-06-04 8:55 ` [PATCH net-next v3 08/10] net: sparx5: add calendar bandwidth allocation support Steen Hegelund
2021-06-04 8:55 ` [PATCH net-next v3 09/10] net: sparx5: add ethtool configuration and statistics support Steen Hegelund
2021-06-04 8:56 ` [PATCH net-next v3 10/10] arm64: dts: sparx5: Add the Sparx5 switch node Steen Hegelund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210607131231.GF22278@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=bjarni.jonasson@microchip.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@oss.nxp.com \
--cc=mark.einon@gmail.com \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=simon.horman@netronome.com \
--cc=steen.hegelund@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).