From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E892C47082 for ; Mon, 7 Jun 2021 17:38:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76807610A1 for ; Mon, 7 Jun 2021 17:38:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230428AbhFGRkX (ORCPT ); Mon, 7 Jun 2021 13:40:23 -0400 Received: from foss.arm.com ([217.140.110.172]:38864 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229997AbhFGRkW (ORCPT ); Mon, 7 Jun 2021 13:40:22 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D16112FC; Mon, 7 Jun 2021 10:38:30 -0700 (PDT) Received: from bogus (unknown [10.57.73.170]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8B1493F73D; Mon, 7 Jun 2021 10:38:28 -0700 (PDT) Date: Mon, 7 Jun 2021 18:38:09 +0100 From: Sudeep Holla To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, Sudeep Holla , vincent.guittot@linaro.org, souvik.chakravarty@arm.com Subject: Re: [RFC PATCH 01/10] firmware: arm_scmi: Reset properly xfer SCMI status Message-ID: <20210607173809.et6fzayvubsosvso@bogus> References: <20210606221232.33768-1-cristian.marussi@arm.com> <20210606221232.33768-2-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210606221232.33768-2-cristian.marussi@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 06, 2021 at 11:12:23PM +0100, Cristian Marussi wrote: > When an SCMI command transfer fails due to some protocol issue an SCMI > error code is reported inside the SCMI message payload itself and it is > then retrieved and transcribed by the specific transport layer into the > xfer.hdr.status field by transport specific .fetch_response(). > > The core SCMI transport layer never explicitly reset xfer.hdr.status, > so when an xfer is reused, if a transport misbehaved in handling such > status field, we risk to see an invalid ghost error code. > > Reset xfer.hdr.status to SCMI_SUCCESS right before each transfer is > started. > Any particular reason why it can't be part of xfer_get_init which has other initialisations ? If none, please move it there. -- Regards, Sudeep