From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08953C47082 for ; Tue, 8 Jun 2021 14:59:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D42D76124C for ; Tue, 8 Jun 2021 14:59:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233702AbhFHPBi (ORCPT ); Tue, 8 Jun 2021 11:01:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:37000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233590AbhFHPBi (ORCPT ); Tue, 8 Jun 2021 11:01:38 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D31D261183; Tue, 8 Jun 2021 14:59:44 +0000 (UTC) Date: Tue, 8 Jun 2021 10:59:43 -0400 From: Steven Rostedt To: Zhen Lei Cc: Ingo Molnar , linux-kernel Subject: Re: [PATCH 1/1] ring-buffer: remove leading spaces before tabs Message-ID: <20210608105943.2376328c@oasis.local.home> In-Reply-To: <20210608081051.13382-1-thunder.leizhen@huawei.com> References: <20210608081051.13382-1-thunder.leizhen@huawei.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Jun 2021 16:10:51 +0800 Zhen Lei wrote: > 1) Run the following command to find and remove the leading spaces before > tabs: > find kernel/trace/ -type f | xargs sed -r -i 's/^[ ]+\t/\t/' > 2) Manually check and correct if necessary > > Signed-off-by: Zhen Lei Sorry, but I do not accept whitespace changes. Clean ups like this is only welcomed if they come along with actual changes to the code around them. Otherwise, this just causes extra churn and unwelcomed work for the maintainer. -- Steve > --- > kernel/trace/ring_buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c > index 833ade3d0b00..a555258556c5 100644 > --- a/kernel/trace/ring_buffer.c > +++ b/kernel/trace/ring_buffer.c > @@ -5887,7 +5887,7 @@ static __init int test_ringbuffer(void) > } > > kthread_bind(rb_threads[cpu], cpu); > - wake_up_process(rb_threads[cpu]); > + wake_up_process(rb_threads[cpu]); > } > > /* Now create the rb hammer! */