* [PATCH rdma-rc] RDMA/mlx5: Block FDB rules when not in switchdev mode
@ 2021-06-07 8:03 Leon Romanovsky
2021-06-08 20:10 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Leon Romanovsky @ 2021-06-07 8:03 UTC (permalink / raw)
To: Doug Ledford, Jason Gunthorpe
Cc: Mark Bloch, linux-kernel, linux-rdma, Maor Gottlieb, Maor Gottlieb
From: Mark Bloch <mbloch@nvidia.com>
Allow creating FDB steering rules only when in switchdev mode.
The only software model where a userspace application can manipulate
FDB entries is when it manages the eswitch. This is only possible in
switchdev mode where we expose a single RDMA device with representors
for all the vports that are connected to the eswitch.
Fixes: 52438be44112 ("RDMA/mlx5: Allow inserting a steering rule to the FDB")
Reviewed-by: Maor Gottlieb <maorg@nvidia.com>
Signed-off-by: Mark Bloch <mbloch@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
drivers/infiniband/hw/mlx5/fs.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/infiniband/hw/mlx5/fs.c b/drivers/infiniband/hw/mlx5/fs.c
index 2fc6a60c4e77..f84441ff0c81 100644
--- a/drivers/infiniband/hw/mlx5/fs.c
+++ b/drivers/infiniband/hw/mlx5/fs.c
@@ -2134,6 +2134,12 @@ static int UVERBS_HANDLER(MLX5_IB_METHOD_FLOW_MATCHER_CREATE)(
if (err)
goto end;
+ if (obj->ns_type == MLX5_FLOW_NAMESPACE_FDB &&
+ mlx5_eswitch_mode(dev->mdev) != MLX5_ESWITCH_OFFLOADS) {
+ err = -EINVAL;
+ goto end;
+ }
+
uobj->object = obj;
obj->mdev = dev->mdev;
atomic_set(&obj->usecnt, 0);
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH rdma-rc] RDMA/mlx5: Block FDB rules when not in switchdev mode
2021-06-07 8:03 [PATCH rdma-rc] RDMA/mlx5: Block FDB rules when not in switchdev mode Leon Romanovsky
@ 2021-06-08 20:10 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2021-06-08 20:10 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Doug Ledford, Mark Bloch, linux-kernel, linux-rdma,
Maor Gottlieb, Maor Gottlieb
On Mon, Jun 07, 2021 at 11:03:12AM +0300, Leon Romanovsky wrote:
> From: Mark Bloch <mbloch@nvidia.com>
>
> Allow creating FDB steering rules only when in switchdev mode.
>
> The only software model where a userspace application can manipulate
> FDB entries is when it manages the eswitch. This is only possible in
> switchdev mode where we expose a single RDMA device with representors
> for all the vports that are connected to the eswitch.
>
> Fixes: 52438be44112 ("RDMA/mlx5: Allow inserting a steering rule to the FDB")
> Reviewed-by: Maor Gottlieb <maorg@nvidia.com>
> Signed-off-by: Mark Bloch <mbloch@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/hw/mlx5/fs.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Applied to for-rc, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-08 20:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-07 8:03 [PATCH rdma-rc] RDMA/mlx5: Block FDB rules when not in switchdev mode Leon Romanovsky
2021-06-08 20:10 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).