From: Leo Yan <leo.yan@linaro.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Daniel Kiss <daniel.kiss@arm.com>,
Denis Nikitin <denik@google.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1 1/3] coresight: etm-perf: Correct buffer syncing for snapshot
Date: Wed, 9 Jun 2021 09:39:09 +0800 [thread overview]
Message-ID: <20210609013909.GE4640@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20210609013555.GD4640@leoy-ThinkPad-X240s>
On Wed, Jun 09, 2021 at 09:35:55AM +0800, Leo Yan wrote:
[...]
> > The problem with this approach is that if the AUX buffer is 4MB and the CS
> > buffer is 1MB then we only record 1MB, but because of N:1 topologies we may not
> > be able to do better. I haven't looked at the code yet, something I will do
> > tomorrow.
>
> Yes, the fixing in this patch copies the trace data is limited by the
> CoreSight bounce buffer length. So if CoreSight buffer length is
> 1MiB, then we have no chance to allocate 4MiB for AUX buffer.
Sorry for typo, just correct:
if CoreSight buffer length is 1MiB, then we have no chance to *copy*
4MiB trace data for AUX buffer.
next prev parent reply other threads:[~2021-06-09 1:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 16:15 [PATCH v1 0/3] coresight: Fix for snapshot mode Leo Yan
2021-05-28 16:15 ` [PATCH v1 1/3] coresight: etm-perf: Correct buffer syncing for snapshot Leo Yan
2021-06-01 9:53 ` James Clark
2021-06-01 10:35 ` Leo Yan
2021-06-10 14:54 ` James Clark
2021-06-11 13:55 ` James Clark
2021-06-08 21:41 ` Mathieu Poirier
2021-06-09 1:35 ` Leo Yan
2021-06-09 1:39 ` Leo Yan [this message]
2021-05-28 16:15 ` [PATCH v1 2/3] coresight: tmc-etr: Use perf_output_handle::head for AUX ring buffer Leo Yan
2021-06-10 15:38 ` Suzuki K Poulose
2021-05-28 16:15 ` [PATCH v1 3/3] perf cs-etm: Remove callback cs_etm_find_snapshot() Leo Yan
2021-06-22 14:29 ` James Clark
2021-06-28 1:31 ` Leo Yan
2021-06-24 16:46 ` James Clark
2021-06-10 6:43 ` [PATCH v1 0/3] coresight: Fix for snapshot mode Denis Nikitin
2021-06-10 16:04 ` Suzuki K Poulose
2021-06-11 8:31 ` Denis Nikitin
2021-06-12 3:27 ` Leo Yan
2021-06-21 8:21 ` Denis Nikitin
2021-06-22 12:58 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609013909.GE4640@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=daniel.kiss@arm.com \
--cc=denik@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).