From: Jakub Kicinski <kuba@kernel.org>
To: Yunsheng Lin <linyunsheng@huawei.com>, <cong.wang@bytedance.com>,
<xiyou.wangcong@gmail.com>, <john.fastabend@gmail.com>,
<mkubecek@suse.cz>
Cc: Vladimir Oltean <olteanv@gmail.com>, <davem@davemloft.net>,
<ast@kernel.org>, <daniel@iogearbox.net>, <andriin@fb.com>,
<edumazet@google.com>, <ap420073@gmail.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@openeuler.org>, <mkl@pengutronix.de>,
<linux-can@vger.kernel.org>, <jhs@mojatatu.com>,
<jiri@resnulli.us>, <andrii@kernel.org>, <kafai@fb.com>,
<songliubraving@fb.com>, <yhs@fb.com>, <kpsingh@kernel.org>,
<bpf@vger.kernel.org>, <jonas.bonn@netrounds.com>,
<pabeni@redhat.com>, <mzhivich@akamai.com>, <johunt@akamai.com>,
<albcamus@gmail.com>, <kehuan.feng@gmail.com>,
<a.fatoum@pengutronix.de>, <atenart@kernel.org>,
<alexander.duyck@gmail.com>, <hdanton@sina.com>,
<jgross@suse.com>, <JKosina@suse.com>, <bjorn@kernel.org>,
<alobakin@pm.me>
Subject: Re: [PATCH net-next v2 0/3] Some optimization for lockless qdisc
Date: Wed, 9 Jun 2021 09:20:16 -0700 [thread overview]
Message-ID: <20210609092016.4c43192f@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <64aaa011-41a3-1e06-af02-909ff329ef7a@huawei.com>
On Wed, 9 Jun 2021 09:31:39 +0800 Yunsheng Lin wrote:
> On 2021/6/8 20:53, Vladimir Oltean wrote:
> > On Thu, Jun 03, 2021 at 11:35:48AM -0700, Jakub Kicinski wrote:
> >> On Thu, 3 Jun 2021 09:47:57 +0800 Yunsheng Lin wrote:
> >>> Patch 1: remove unnecessary seqcount operation.
> >>> Patch 2: implement TCQ_F_CAN_BYPASS.
> >>> Patch 3: remove qdisc->empty.
> >>>
> >>> Performance data for pktgen in queue_xmit mode + dummy netdev
> >>> with pfifo_fast:
> >>>
> >>> threads unpatched patched delta
> >>> 1 2.60Mpps 3.21Mpps +23%
> >>> 2 3.84Mpps 5.56Mpps +44%
> >>> 4 5.52Mpps 5.58Mpps +1%
> >>> 8 2.77Mpps 2.76Mpps -0.3%
> >>> 16 2.24Mpps 2.23Mpps +0.4%
> >>>
> >>> Performance for IP forward testing: 1.05Mpps increases to
> >>> 1.16Mpps, about 10% improvement.
> >>
> >> Acked-by: Jakub Kicinski <kuba@kernel.org>
> >
> > Any idea why these patches are deferred in patchwork?
> > https://patchwork.kernel.org/project/netdevbpf/cover/1622684880-39895-1-git-send-email-linyunsheng@huawei.com/
>
> I suppose it is a controversial change, which need more time
> hanging to be reviewed and tested.
That'd be my guess also. A review from area experts would be great,
perhaps from Cong, John, Michal.. If the review doesn't come by
Friday - I'd repost.
next prev parent reply other threads:[~2021-06-09 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 1:47 [PATCH net-next v2 0/3] Some optimization for lockless qdisc Yunsheng Lin
2021-06-03 1:47 ` [PATCH net-next v2 1/3] net: sched: avoid unnecessary seqcount operation " Yunsheng Lin
2021-06-03 1:47 ` [PATCH net-next v2 2/3] net: sched: implement TCQ_F_CAN_BYPASS " Yunsheng Lin
2021-06-03 1:48 ` [PATCH net-next v2 3/3] net: sched: remove qdisc->empty " Yunsheng Lin
2021-06-03 18:35 ` [PATCH net-next v2 0/3] Some optimization " Jakub Kicinski
2021-06-08 12:53 ` Vladimir Oltean
2021-06-09 1:31 ` Yunsheng Lin
2021-06-09 16:20 ` Jakub Kicinski [this message]
2021-06-15 23:29 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609092016.4c43192f@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=JKosina@suse.com \
--cc=a.fatoum@pengutronix.de \
--cc=albcamus@gmail.com \
--cc=alexander.duyck@gmail.com \
--cc=alobakin@pm.me \
--cc=andrii@kernel.org \
--cc=andriin@fb.com \
--cc=ap420073@gmail.com \
--cc=ast@kernel.org \
--cc=atenart@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hdanton@sina.com \
--cc=jgross@suse.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=johunt@akamai.com \
--cc=jonas.bonn@netrounds.com \
--cc=kafai@fb.com \
--cc=kehuan.feng@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=linyunsheng@huawei.com \
--cc=mkl@pengutronix.de \
--cc=mkubecek@suse.cz \
--cc=mzhivich@akamai.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=songliubraving@fb.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).