From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09C66C48BCD for ; Wed, 9 Jun 2021 11:57:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E504061263 for ; Wed, 9 Jun 2021 11:57:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239659AbhFIL7O convert rfc822-to-8bit (ORCPT ); Wed, 9 Jun 2021 07:59:14 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:43267 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239686AbhFIL7H (ORCPT ); Wed, 9 Jun 2021 07:59:07 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id B398724000B; Wed, 9 Jun 2021 11:57:08 +0000 (UTC) Date: Wed, 9 Jun 2021 13:57:07 +0200 From: Miquel Raynal To: Krzysztof Kozlowski Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , linux-mtd@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org, Michal Simek , Naga Sureshkumar Relli , Amit Kumar Mahapatra , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, helmut.grohne@intenta.de, Srinivas Goud , Siva Durga Prasad Paladugu Subject: Re: [PATCH v22 12/18] memory: pl353-smc: Let lower level controller drivers handle inits Message-ID: <20210609135707.6c9c67cc@xps13> In-Reply-To: References: <20210609080112.1753221-1-miquel.raynal@bootlin.com> <20210609080112.1753221-13-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, Krzysztof Kozlowski wrote on Wed, 9 Jun 2021 13:54:24 +0200: > On 09/06/2021 10:01, Miquel Raynal wrote: > > There is no point in having all these definitions at the SMC bus level, > > these are extremely tight to the NAND controller driver implementation, > > are not particularly generic, imply more boilerplate than needed, do > > not really follow the device model by receiving no argument and some of > > them are actually buggy. > > > > Let's get rid of these right now as there is no current user and keep > > this driver at a simple level: only the SMC bare initializations. > > > > The NAND controller driver which I am going to introduce will take care > > of redefining properly all these helpers and using them directly. > > > > Signed-off-by: Miquel Raynal > > --- > > drivers/memory/pl353-smc.c | 294 ------------------------------------- > > include/linux/pl353-smc.h | 30 ---- > > 2 files changed, 324 deletions(-) > > delete mode 100644 include/linux/pl353-smc.h > > > > I see you remove here a bunch of code. Are the series still fully > bisectable? Absolutely, yes, because this code is currently unused. Thanks, Miquèl