From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
linux-mtd@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Michal Simek <monstr@monstr.eu>,
Naga Sureshkumar Relli <nagasure@xilinx.com>,
Amit Kumar Mahapatra <akumarma@xilinx.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, helmut.grohne@intenta.de,
Srinivas Goud <sgoud@xilinx.com>,
Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Subject: Re: [PATCH v22 09/18] dt-binding: memory: pl353-smc: Convert to yaml
Date: Wed, 9 Jun 2021 16:11:28 +0200 [thread overview]
Message-ID: <20210609161128.16cdf5ec@xps13> (raw)
In-Reply-To: <77db74d3-c44a-6aa3-1b61-f6bed565fa04@canonical.com>
Hi Krzysztof, Rob,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote on Wed, 9
Jun 2021 15:54:19 +0200:
> On 09/06/2021 15:34, Miquel Raynal wrote:
> > Hi Krzysztof,
> >
> > Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote on Wed, 9
> > Jun 2021 14:12:40 +0200:
> >
> >> On 09/06/2021 10:01, Miquel Raynal wrote:
> >>> Convert this binding file to yaml schema.
> >>>
> >>> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> >>> ---
> >>> .../memory-controllers/arm,pl353-smc.yaml | 133 ++++++++++++++++++
> >>> .../bindings/memory-controllers/pl353-smc.txt | 45 ------
> >>> 2 files changed, 133 insertions(+), 45 deletions(-)
> >>> create mode 100644 Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml
> >>> delete mode 100644 Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml b/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml
> >>> new file mode 100644
> >>> index 000000000000..1de6f87d4986
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml
> >>> @@ -0,0 +1,133 @@
> >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >>> +%YAML 1.2
> >>> +---
> >>> +$id: http://devicetree.org/schemas/memory-controllers/arm,pl353-smc.yaml#
> >>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >>> +
> >>> +title: ARM PL353 Static Memory Controller (SMC) device-tree bindings
> >>> +
> >>> +maintainers:
> >>> + - Miquel Raynal <miquel.raynal@bootlin.com>
> >>> + - Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
> >>> +
> >>> +description:
> >>> + The PL353 Static Memory Controller is a bus where you can connect two kinds
> >>> + of memory interfaces, which are NAND and memory mapped interfaces (such as
> >>> + SRAM or NOR).
> >>> +
> >>> +# We need a select here so we don't match all nodes with 'arm,primecell'
> >>> +select:
> >>> + properties:
> >>> + compatible:
> >>> + contains:
> >>> + enum:
> >>> + - arm,pl353-smc-r2p1
> >>
> >> That's a const... but also I don't get the need for select.
> >
> > I think this is needed to ensure this binding is not enforced against
> > arm,primecell compatible nodes which are not featuring the
> > arm,pl353-smc-r2p1 compatible.
>
> Which seems to be result of unusual compatible match, so once you
> convert to regular match, this select is not needed.
I don't think so, I received a hint from Rob some time ago, he told
me to add this additional select line as in all other arm,primecell
binding.
Rob, any additional info regarding this?
> >>> +
> >>> + "#address-cells":
> >>> + const: 2
> >>> +
> >>> + "#size-cells":
> >>> + const: 1
> >>> +
> >>> + reg:
> >>> + items:
> >>> + - description: configuration registers for the host and sub-controllers
> >>
> >> Just maxItems. Description is obvious.
> >
> > I don't think it is that obvious because there are actually 4 areas
> > and, because of the yaml language, we only describe one in the reg
> > property while the others and defined in the ranges property, but
> > that's fine by me, I'll drop the description and stick to a
> > maxItems entry.
>
> The explanation of all four areas could have sense, but now it states
> the obvious - these are configuration registers :)
Well, that's true :)
Thanks,
Miquèl
next prev parent reply other threads:[~2021-06-09 14:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 8:00 [PATCH v22 00/18] ARM Primecell PL35x support Miquel Raynal
2021-06-09 8:00 ` [PATCH v22 01/18] dt-binding: memory: pl353-smc: Rephrase the binding Miquel Raynal
2021-06-09 8:00 ` [PATCH v22 02/18] dt-binding: memory: pl353-smc: Document the range property Miquel Raynal
2021-06-09 8:00 ` [PATCH v22 03/18] dt-binding: memory: pl353-smc: Drop the partitioning section Miquel Raynal
2021-06-09 8:00 ` [PATCH v22 04/18] dt-binding: memory: pl353-smc: Describe the child reg property Miquel Raynal
2021-06-09 8:00 ` [PATCH v22 05/18] dt-binding: memory: pl353-smc: Fix the example syntax and style Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 06/18] dt-binding: memory: pl353-smc: Drop unsupported nodes from the example Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 07/18] dt-binding: memory: pl353-smc: Fix the NAND controller node in " Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 08/18] dt-binding: memory: pl353-smc: Enhance the description of the reg property Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 09/18] dt-binding: memory: pl353-smc: Convert to yaml Miquel Raynal
2021-06-09 12:12 ` Krzysztof Kozlowski
2021-06-09 13:34 ` Miquel Raynal
2021-06-09 13:54 ` Krzysztof Kozlowski
2021-06-09 14:11 ` Miquel Raynal [this message]
2021-06-09 15:26 ` Krzysztof Kozlowski
2021-06-09 19:26 ` Rob Herring
2021-06-09 19:35 ` Rob Herring
2021-06-09 16:16 ` Rob Herring
2021-06-09 8:01 ` [PATCH v22 10/18] memory: pl353-smc: Fix style Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 11/18] memory: pl353-smc: Rename goto labels Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 12/18] memory: pl353-smc: Let lower level controller drivers handle inits Miquel Raynal
2021-06-09 11:54 ` Krzysztof Kozlowski
2021-06-09 11:57 ` Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 13/18] memory: pl353-smc: Avoid useless acronyms in descriptions Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 14/18] memory: pl353-smc: Declare variables following a reverse christmas tree order Miquel Raynal
2021-06-09 8:01 ` [PATCH v22 15/18] MAINTAINERS: Add PL353 SMC entry Miquel Raynal
2021-06-09 13:23 ` Krzysztof Kozlowski
2021-06-09 13:41 ` Miquel Raynal
2021-06-10 7:04 ` Naga Sureshkumar Relli
2021-06-09 8:01 ` [PATCH v22 16/18] MAINTAINERS: Add PL353 NAND controller entry Miquel Raynal
2021-06-10 7:05 ` Naga Sureshkumar Relli
2021-06-09 8:01 ` [PATCH v22 17/18] dt-bindings: mtd: pl353-nand: Describe this hardware controller Miquel Raynal
2021-06-09 12:01 ` Krzysztof Kozlowski
2021-06-09 13:36 ` Miquel Raynal
2021-06-09 13:57 ` Krzysztof Kozlowski
2021-06-10 2:32 ` Rob Herring
2021-06-09 16:16 ` Rob Herring
2021-06-09 19:36 ` Rob Herring
2021-06-09 8:01 ` [PATCH v22 18/18] mtd: rawnand: pl353: Add support for the ARM PL353 SMC NAND controller Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609161128.16cdf5ec@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=akumarma@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=helmut.grohne@intenta.de \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=monstr@monstr.eu \
--cc=nagasure@xilinx.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sgoud@xilinx.com \
--cc=sivadur@xilinx.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).