From: David Miller <davem@davemloft.net>
To: hbut_tan@163.com
Cc: elder@kernel.org, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, tanzhongjun@yulong.com
Subject: Re: [PATCH] soc: qcom: ipa: Remove superfluous error message around platform_get_irq()
Date: Thu, 10 Jun 2021 14:11:42 -0700 (PDT) [thread overview]
Message-ID: <20210610.141142.1384244468678097702.davem@davemloft.net> (raw)
In-Reply-To: <20210610140118.1437-1-hbut_tan@163.com>
From: Zhongjun Tan <hbut_tan@163.com>
Date: Thu, 10 Jun 2021 22:01:18 +0800
> diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c
> index 34b68dc43886..93270e50b6b3 100644
> --- a/drivers/net/ipa/ipa_smp2p.c
> +++ b/drivers/net/ipa/ipa_smp2p.c
> @@ -177,11 +177,8 @@ static int ipa_smp2p_irq_init(struct ipa_smp2p *smp2p, const char *name,
> int ret;
>
> ret = platform_get_irq_byname(smp2p->ipa->pdev, name);
> - if (ret <= 0) {
> - dev_err(dev, "DT error %d getting \"%s\" IRQ property\n",
> - ret, name);
> + if (ret <= 0)
Applied, but this code still rejects an irq of zero which is a valid irq number.
next prev parent reply other threads:[~2021-06-10 21:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 14:01 [PATCH] soc: qcom: ipa: Remove superfluous error message around platform_get_irq() Zhongjun Tan
2021-06-10 21:11 ` David Miller [this message]
2021-06-10 21:38 ` Alex Elder
2021-06-11 3:04 ` Zhongjun Tan
2021-06-10 21:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610.141142.1384244468678097702.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=hbut_tan@163.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tanzhongjun@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).