From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF13DC48BD1 for ; Thu, 10 Jun 2021 01:14:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0724613FF for ; Thu, 10 Jun 2021 01:14:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229874AbhFJBQ0 (ORCPT ); Wed, 9 Jun 2021 21:16:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:44534 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229655AbhFJBQZ (ORCPT ); Wed, 9 Jun 2021 21:16:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D3AA4613FF; Thu, 10 Jun 2021 01:14:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623287670; bh=3933pBynZO3J3T2i9LqHlsaYhO2NNvTednt0+lPKRXQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W0FS1EUiBdWPHk+2pZu96ZmL81CYmxdBjcNvlOOaRwKdAT8kSF27X/NkcSTx4ckGl tZt/K1Mn8Mc/g1GVSXwzgGL75rXYTDGb+Xax/oNk1umWonpN+I3Uhx41d5uTqApQQh 0vWwsfxaCtRCL7iikdvcuWwCeKEWnwu/Ar7ABKgy2xG+jEVJNg98coH2BZmclVZvdZ LLp/YrC/CyoAp0teHpAfynxDdZy9p4iUm0tr115q13AGmRErEf1R5DxqBIpQVXcrLT YUL018pr2vyrJ1hMST9A8bRRXKJ43kz7WkvAinridL2zy6ukPvnQEorfX2VekioFUP g6W6kLdofN2PQ== Date: Thu, 10 Jun 2021 09:14:25 +0800 From: Peter Chen To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Felipe Balbi , Jack Pham Subject: Re: [PATCH] USB: dwc3: remove debugfs root dentry storage Message-ID: <20210610011425.GA6592@nchen> References: <20210609093924.3293230-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210609093924.3293230-1-gregkh@linuxfoundation.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21-06-09 11:39:24, Greg Kroah-Hartman wrote: > There is no need to keep around the debugfs "root" directory for the > dwc3 device. Instead, look it up anytime we need to find it. This will > help when callers get out-of-order and we had the potential to have a > "stale" pointer around for the root dentry, as has happened in the past. > > Cc: Felipe Balbi > Cc: Jack Pham > Cc: Peter Chen > Signed-off-by: Greg Kroah-Hartman Reviewed-by: Peter Chen > --- > drivers/usb/dwc3/core.h | 2 -- > drivers/usb/dwc3/debugfs.c | 8 ++++---- > drivers/usb/dwc3/gadget.c | 4 +++- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > index c5d5760cdf53..dccdf13b5f9e 100644 > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -1013,7 +1013,6 @@ struct dwc3_scratchpad_array { > * @link_state: link state > * @speed: device speed (super, high, full, low) > * @hwparams: copy of hwparams registers > - * @root: debugfs root folder pointer > * @regset: debugfs pointer to regdump file > * @dbg_lsp_select: current debug lsp mux register selection > * @test_mode: true when we're entering a USB test mode > @@ -1222,7 +1221,6 @@ struct dwc3 { > u8 num_eps; > > struct dwc3_hwparams hwparams; > - struct dentry *root; > struct debugfs_regset32 *regset; > > u32 dbg_lsp_select; > diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c > index 5dbbe53269d3..f2b7675c7f62 100644 > --- a/drivers/usb/dwc3/debugfs.c > +++ b/drivers/usb/dwc3/debugfs.c > @@ -889,8 +889,10 @@ static void dwc3_debugfs_create_endpoint_files(struct dwc3_ep *dep, > void dwc3_debugfs_create_endpoint_dir(struct dwc3_ep *dep) > { > struct dentry *dir; > + struct dentry *root; > > - dir = debugfs_create_dir(dep->name, dep->dwc->root); > + root = debugfs_lookup(dev_name(dep->dwc->dev), usb_debug_root); > + dir = debugfs_create_dir(dep->name, root); > dwc3_debugfs_create_endpoint_files(dep, dir); > } > > @@ -909,8 +911,6 @@ void dwc3_debugfs_init(struct dwc3 *dwc) > dwc->regset->base = dwc->regs - DWC3_GLOBALS_REGS_START; > > root = debugfs_create_dir(dev_name(dwc->dev), usb_debug_root); > - dwc->root = root; > - > debugfs_create_regset32("regdump", 0444, root, dwc->regset); > debugfs_create_file("lsp_dump", 0644, root, dwc, &dwc3_lsp_fops); > > @@ -929,6 +929,6 @@ void dwc3_debugfs_init(struct dwc3 *dwc) > > void dwc3_debugfs_exit(struct dwc3 *dwc) > { > - debugfs_remove_recursive(dwc->root); > + debugfs_remove(debugfs_lookup(dev_name(dwc->dev), usb_debug_root)); > kfree(dwc->regset); > } > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index 7cc99b6d0bfe..026a2ad0fc80 100644 > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -2799,7 +2799,9 @@ static void dwc3_gadget_free_endpoints(struct dwc3 *dwc) > list_del(&dep->endpoint.ep_list); > } > > - debugfs_remove_recursive(debugfs_lookup(dep->name, dwc->root)); > + debugfs_remove_recursive(debugfs_lookup(dep->name, > + debugfs_lookup(dev_name(dep->dwc->dev), > + usb_debug_root))); > kfree(dep); > } > } > -- > 2.32.0 > -- Thanks, Peter Chen