From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C0E7C48BDF for ; Thu, 10 Jun 2021 14:39:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EAF6613F1 for ; Thu, 10 Jun 2021 14:39:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231501AbhFJOl1 (ORCPT ); Thu, 10 Jun 2021 10:41:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:57872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231213AbhFJOl0 (ORCPT ); Thu, 10 Jun 2021 10:41:26 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B510613E3; Thu, 10 Jun 2021 14:39:29 +0000 (UTC) Date: Thu, 10 Jun 2021 10:39:27 -0400 From: Steven Rostedt To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-users@vger.kernel.org, Tzvetomir Stoyanov , eranian@google.com Subject: Re: [RFC PATCH] libtraceevent: Increase libtraceevent logging when verbose Message-ID: <20210610103927.44462e35@oasis.local.home> In-Reply-To: <20210610060643.595673-1-irogers@google.com> References: <20210610060643.595673-1-irogers@google.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Jun 2021 23:06:43 -0700 Ian Rogers wrote: > libtraceevent has added more levels of debug printout and with changes > like: > https://lore.kernel.org/linux-trace-devel/20210507095022.1079364-3-tz.stoyanov@gmail.com > previously generated output like "registering plugin" is no longer > displayed. This change makes it so that if perf's verbose debug output > is enabled then the debug and info libtraceevent messages can be > displayed. > As this API isn't present in the deprecated tools version of > libtracevent I'm uploading this as an RFC. Thanks Ian, We need to start porting perf to using the upstream libtraceevent library. I think the best way to do that is what we did with trace-cmd. That is to have the make files check if the minimum version of libtraceevent is installed, and if so, use that instead of the local version. If it is not installed, produce a message encouraging the developer to install the upstream libtraceevent and warn that it will be using a deprecated older versino, then build the deprecated local version. After some time, we could simply remove it and make it a dependency, but I want to do that when all the main distros being used have it. Currently its in the latest Debian, Ubuntu, and Fedora. I also believe its in SUSE but have not checked. It's in Fedora 34, but it doesn't appear to be in Fedora 33. As that's not too old, I don't think we should make it a dependency as of yet. -- Steve