From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BB3FC48BDF for ; Thu, 10 Jun 2021 11:35:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19A14613FE for ; Thu, 10 Jun 2021 11:35:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230303AbhFJLhA (ORCPT ); Thu, 10 Jun 2021 07:37:00 -0400 Received: from mail-pf1-f175.google.com ([209.85.210.175]:34344 "EHLO mail-pf1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230289AbhFJLg6 (ORCPT ); Thu, 10 Jun 2021 07:36:58 -0400 Received: by mail-pf1-f175.google.com with SMTP id g6so1375421pfq.1 for ; Thu, 10 Jun 2021 04:35:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IAYWQy/NatfpIcXJIRpsRB5B4j7vaD9GdXi8w2oAwB0=; b=W5pUG3St5KymyWOc7NfMZB9I5KV6ob7gbyVykdBi9XBvrZtPeYW1ArRBP0hOrligL7 +aXXVJRJGYssqUraDO+Icq6cABG4gEP2NoqB+z2kSuf2/HJIJjuKNFoyQ0lHOkjtb8Hd mQnoyD/K0gdtxbGnlYQF3iPN2MkZuFuKVQvD1VpNX0ytJtnBefV3aFP+/ikMttzukk/M s/m+KiBPfs0JDOyxaRvmrWVIBwXTeCwrHoV/CA05rb4vCNvH47tTS1wDO0xpVVQXvPjb Vl9vhC8Ays1Oa3KyIr77Gx8LrzT8SMhj6GCCUmUy3h2tXuoO0znhCMi092PiB4WE+kuJ DEfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IAYWQy/NatfpIcXJIRpsRB5B4j7vaD9GdXi8w2oAwB0=; b=L4p6qjJs+onZoHiE9gL/jaFTFMtsIaHryrsjWxYtrrF774cZBa1gX6KwihzZ8XZisC n31upgt6uH6j6WUfa90S0J1t0BQx1lRFCycqjFkZPFs1UrPoqmpXX2wfLlTF6/Z8DwF6 f710W0rPt6D4Lw0c70+G9RSvYrekxZxo7fSJJTHisV6k/C/9R9NCSncnuffPbnr2NxYu 52apGjNOU3IyqidNKmFBghpbVxNTItbQIhSlh30ILQxPwkNCQBeNVM6O0/QIeOVV15+k MzZIVF5Lz3TwdZKsYLhvM4j01W0aVl7F7D0td9uFCsOefm28nUJLtE3Q3QDjgUQKVZo9 i4zQ== X-Gm-Message-State: AOAM5323jQMAm/4FCnafDp0fqeLk/788v3zOjA18RUu3PH45Hva9XRyZ tT1qqnHEqOnSbHgpjniBw1hXiA== X-Google-Smtp-Source: ABdhPJx2wjAW6NK3r+kW3K0nffrtvAGOgWQTRJxfHls6ATvVpriTrEbU3Eb3w9qKs+rc2DfC1aZkqA== X-Received: by 2002:a63:5c4:: with SMTP id 187mr4616940pgf.368.1623324842169; Thu, 10 Jun 2021 04:34:02 -0700 (PDT) Received: from localhost ([136.185.169.128]) by smtp.gmail.com with ESMTPSA id n8sm7738416pjo.1.2021.06.10.04.34.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 04:34:01 -0700 (PDT) Date: Thu, 10 Jun 2021 17:03:59 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Rafael Wysocki , Ionela Voinescu , Linux PM , Vincent Guittot , Qian Cai , Linux Kernel Mailing List Subject: Re: [PATCH] cpufreq: cppc: Mark frequency invariance broken Message-ID: <20210610113359.gb2cu3miwuo44d5b@vireshk-i7> References: <28308fc0d38f252baf90e6ffb31fd2f8660be273.1623311808.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10-06-21, 13:19, Rafael J. Wysocki wrote: > On Thu, Jun 10, 2021 at 9:58 AM Viresh Kumar wrote: > > > > There are few races in the frequency invariance support for CPPC driver, > > namely the driver doesn't stop the kthread_work and irq_work on policy > > exit during suspend/resume or CPU hotplug. > > > > A proper fix won't be possible for the 5.13-rc, as it requires a lot of > > changes. Instead of reverting the patch, mark this feature BROKEN for > > now. > > > > Fixes: 4c38f2df71c8 ("cpufreq: CPPC: Add support for frequency invariance") > > Reported-by: Qian Cai > > Signed-off-by: Viresh Kumar > > Well, why don't we revert 4c38f2df71c8 instead? > > Is there any particular reason for retaining it? I was just trying to reduce the diff size here, since this feature (which broke) was controlled by a CONFIG option, it looked like a nice way of doing it. It was already reviewed and a diff over it should be easier to review. I can do a full revert if that's what you want. -- viresh