From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99E8CC48BD1 for ; Thu, 10 Jun 2021 12:27:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82D0561285 for ; Thu, 10 Jun 2021 12:27:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230363AbhFJM24 (ORCPT ); Thu, 10 Jun 2021 08:28:56 -0400 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]:54699 "EHLO wnew3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230350AbhFJM2k (ORCPT ); Thu, 10 Jun 2021 08:28:40 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.west.internal (Postfix) with ESMTP id 193091EC9; Thu, 10 Jun 2021 08:26:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 10 Jun 2021 08:26:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=COkkJeYcvwmDlhpVmcIauI0ShUX vSvQARYR7Bn0tqj4=; b=G41sR6gjk5D5n5+FAAgCsTkZaWGX63tNhkvr9KZMQQa kD5xsbgJS4XyFwXzV5Q/f4SBi3DBuRTSsUaeYxwoP2NOBJh69atOAEGcwrAhIVU8 20vpJ72V62SztQzyMH9C5HZG5TUnVluRMXH2fzDigiuu9ECr70ZHrxg4Qy7IvyZ5 XwDcRkgE3fnu9M2pZzNCrEUydH1gKmEAniNMwscrUUGPaPqCnGAj4GX40+R7P1tk PEwIx9B3+gh5izlDpR/B9pus4aE4puPISZ9WCVYXZeCx0krKQh59tSew2E4vpKU/ gqQGEuG3BX0vPBj7/uGa29kHeUBzw/bYKhrDSvJSUEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=COkkJe YcvwmDlhpVmcIauI0ShUXvSvQARYR7Bn0tqj4=; b=ICOyP9St7jwWbGIlx3CNCY prS1VY8z8pCBlkiiJufnszVcTDQ6oUi9oGOmAqXZaNjCkfKzZ1l/AUbW75BLyWYD d4ILtT1YWKvb0+FtgNoJmkd8vNXnSurrJNuF0U+kcOTu4BObkY8RMYWV+ZOKJ7rI ZQZzrYJIG3UL0I5P/4ve7LiAURdYQyy3MyePB7TIDDEAw+p9Qqz8+IIfVOS3ng1J G9y43mVHwGczXVMNOJyxSQcxjGXGSluVvlLhSH284NIdVZCeYDuKyW1ieArs4pz+ 6pFTapf57ZUlsnacwOnsbyC3MoFck26ZQ9cpnwOF0F0rq3fekwKyxBHp0oSWtoVQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedufedgheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 10 Jun 2021 08:26:39 -0400 (EDT) Date: Thu, 10 Jun 2021 14:26:36 +0200 From: Maxime Ripard To: Mark Brown Cc: Jaroslav Kysela , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , Liam Girdwood , Takashi Iwai , devicetree@vger.kernel.org, Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , linux-doc@vger.kernel.org, Eric Anholt , Nicolas Saenz Julienne , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, Daniel Vetter , linux-rpi-kernel@lists.infradead.org, Jonathan Corbet , Rob Herring Subject: Re: [PATCH v2 04/12] ASoC: hdmi-codec: Add iec958 controls Message-ID: <20210610122636.nrzq4edube4e4xx5@gilmour> References: <20210525132354.297468-1-maxime@cerno.tech> <20210525132354.297468-5-maxime@cerno.tech> <20210609124304.GB5052@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ca7v7tdvp4h73ynz" Content-Disposition: inline In-Reply-To: <20210609124304.GB5052@sirena.org.uk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ca7v7tdvp4h73ynz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Mark On Wed, Jun 09, 2021 at 01:43:04PM +0100, Mark Brown wrote: > On Tue, May 25, 2021 at 03:23:46PM +0200, Maxime Ripard wrote: > > The IEC958 status bits can be exposed and modified by the userspace > > through dedicated ALSA controls. > >=20 > > This patch implements those controls for the hdmi-codec driver. It > > relies on a default value being setup at probe time that can later be > > overridden by the control put. >=20 > This breaks bisection: >=20 > /mnt/kernel/sound/soc/codecs/hdmi-codec.c: In function 'hdmi_codec_hw_par= ams': > /mnt/kernel/sound/soc/codecs/hdmi-codec.c:504:50: error: invalid type arg= ument of '->' (have 'struct hdmi_codec_params') > memcpy(hp.iec.status, hcp->iec_status, sizeof(hp->iec_status)); > ^~ Indeed, sorry. I just sent a new version of the PR with that breakage fixed Maxime --ca7v7tdvp4h73ynz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYMIE/AAKCRDj7w1vZxhR xRTlAP9A1B518vIEh0yPmEb88zrbl9iK6pcUuknr9pf2xJtwUAEA/rrMwlBSRpR8 Y+nhnpOTpFudYyX6DNXdi97U/IRptgk= =GVe1 -----END PGP SIGNATURE----- --ca7v7tdvp4h73ynz--