From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6F87C48BE0 for ; Thu, 10 Jun 2021 14:17:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC6A3613C6 for ; Thu, 10 Jun 2021 14:17:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231328AbhFJOTa (ORCPT ); Thu, 10 Jun 2021 10:19:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:43198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230387AbhFJOTY (ORCPT ); Thu, 10 Jun 2021 10:19:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EB7F2613D9; Thu, 10 Jun 2021 14:17:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623334648; bh=RsxEWAIXQZfs+po6RGl38wHzZWi2MVveikiBWMNibGA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H6FObbXCb9egJCrCRk6BZlkp8VdSKvXFpU1mIWh4XaMIAokIiMql2pZt7pp9B8Ipj DnxFKjsbC63dDVQ52j0itePU2TbtLszEwqpWcEWMpcyqQUmCdGu+26y+VAqqmtf5lr aFiN2kmxRXk2MeLsGBFGVhoEsF8vD6eahiD7Fy7Q27H2PL9xht4rKwWVRSmHud5ali OHB3T2fwpHL5wpwCp9fC68aNb0Xsh8kplyKiwS4FAMTc7VnZP29BiuTo8CbuGDxA4l xtud/0UMz4utFQHmTy7Am0kVJv0/uclE4EIeLoxKmUDFkVkT2kMFKmkqrNmEd2smpo greg0Ehg8vgkQ== Date: Thu, 10 Jun 2021 22:17:12 +0800 From: Peter Chen To: Baokun Li Cc: linux-kernel@vger.kernel.org, Pawel Laszczak , Greg Kroah-Hartman , weiyongjun1@huawei.com, yuehaibing@huawei.com, yangjihong1@huawei.com, yukuai3@huawei.com, linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot Subject: Re: [PATCH -next v2] usb: cdns3: cdns3-gadget: Use list_move_tail instead of list_del/list_add_tail Message-ID: <20210610141712.GB7839@Peter> References: <20210609072720.1358527-1-libaokun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210609072720.1358527-1-libaokun1@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21-06-09 15:27:20, Baokun Li wrote: > Using list_move_tail() instead of list_del() + list_add_tail(). > > Reported-by: Hulk Robot > Signed-off-by: Baokun Li > --- > V1->V2: > CC mailist > > drivers/usb/cdns3/cdns3-gadget.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c > index 57adcdbfab5f..5d8c982019af 100644 > --- a/drivers/usb/cdns3/cdns3-gadget.c > +++ b/drivers/usb/cdns3/cdns3-gadget.c > @@ -430,9 +430,7 @@ static int cdns3_start_all_request(struct cdns3_device *priv_dev, > if (ret) > return ret; > > - list_del(&request->list); > - list_add_tail(&request->list, > - &priv_ep->pending_req_list); > + list_move_tail(&request->list, &priv_ep->pending_req_list); > if (request->stream_id != 0 || (priv_ep->flags & EP_TDLCHK_EN)) > break; > } > Applied, thanks. -- Thanks, Peter Chen