From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A7C9C48BD1 for ; Thu, 10 Jun 2021 14:31:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27891613FE for ; Thu, 10 Jun 2021 14:31:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231463AbhFJOdH (ORCPT ); Thu, 10 Jun 2021 10:33:07 -0400 Received: from mail-pj1-f42.google.com ([209.85.216.42]:44839 "EHLO mail-pj1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230298AbhFJOdG (ORCPT ); Thu, 10 Jun 2021 10:33:06 -0400 Received: by mail-pj1-f42.google.com with SMTP id h12-20020a17090aa88cb029016400fd8ad8so3944959pjq.3 for ; Thu, 10 Jun 2021 07:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WAIw/Rwu5BfzassT+alfD6qJ0zIc5FQswOka0Hsn+Pg=; b=oAab248luw/C5YmYfz26rJUXz6+AudYZgoU4tBw4OAkwGUfZbTYC0PCUQCvmemil9s SlKYgcXVFiXYGxbNuzDLPru/ac9L6ZlviSO6mQabLWTjDL5A2dZJnFqX83Ic1IMOVO2y 5jK8L4OUBY90qde3m7NOkr6VihMxRANPf6sxHPM8b9mqI8GGVuxGEFf2gQjb07+XVOoO kdZC/amW8Ed49gMS24E1zjDmVIEOndDu6q6NhgoR1+frgiU3oaRXKGcGt2/jP4SmCveU X2XFTbWIFYh22WkwMlwR8UDGQvnHXmq66ukf0tskFtuJZZsKjckl25ggCr+Dha4NUwhr t3hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WAIw/Rwu5BfzassT+alfD6qJ0zIc5FQswOka0Hsn+Pg=; b=YsyMgrvY2nN7anBkrYGI7oCI6zrQIulrT2iVKuZsFbBZhbMyaO+k9E0t5vraAcFjnr G30VPOq3Dv4e7/iKFgPFn4ZXNG2Koe+US2dNS3yrZFvSQSvIpUjqu7c5E/CCIqS52/ea VFPNKAfAVBmXpFiezgsd51wEuMum0xuV+2gAPTOLhYqnWQpAFa98F8hOO62zIF2RjzFB /tfXIvkEpcJaN2Qprq9jI3mNHUEUgHB6r3v5ULjc4vuiz2TnO53imkvY477LdYY0Uwum nCR5TSAaNhuG1t0uuH/QO9TOwE06FQHKSMeDVAKjoJsfHns5+WTbQfsgbRzfpTgXoAh3 HuAg== X-Gm-Message-State: AOAM532dOkrmZ3HnAu+Zeb+fHtI/jjfIJVODM9Qoa6GqD1mNMFp9ByxR j+oss22DZBg7xj6lA3i9AF2v X-Google-Smtp-Source: ABdhPJy5V2yMkuXeobYWfKg0xU3WwZDRykGMwSqfzVQPY47TpPPxpWkpgmeMmwq2ZBIT2d+aMmc9Zg== X-Received: by 2002:a17:90a:80c5:: with SMTP id k5mr3697723pjw.129.1623335400290; Thu, 10 Jun 2021 07:30:00 -0700 (PDT) Received: from thinkpad ([2409:4072:6d9e:80ad:d341:9a16:2c5c:2249]) by smtp.gmail.com with ESMTPSA id o3sm2715814pfd.41.2021.06.10.07.29.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 07:29:59 -0700 (PDT) Date: Thu, 10 Jun 2021 19:59:53 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Cc: Stephen Boyd , Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , Michael Turquette , Edgar Bernardi Righi , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 2/6] clk: actions: Fix SD clocks factor table on Owl S500 SoC Message-ID: <20210610142953.GA315240@thinkpad> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 27, 2021 at 04:16:40PM +0300, Cristian Ciocaltea wrote: > Drop the unsupported entries in the factor table used for the SD[0-2] > clocks definitions on the Actions Semi Owl S500 SoC. > > Fixes: ed6b4795ece4 ("clk: actions: Add clock driver for S500 SoC") > Signed-off-by: Cristian Ciocaltea Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > Changes in v2: > - Re-added entry "{ 24, 1, 25 }" to sd_factor_table, according to the > datasheet (V1.8+), this is a valid divider > > drivers/clk/actions/owl-s500.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/actions/owl-s500.c b/drivers/clk/actions/owl-s500.c > index 75b7186185b0..42abdf964044 100644 > --- a/drivers/clk/actions/owl-s500.c > +++ b/drivers/clk/actions/owl-s500.c > @@ -127,8 +127,7 @@ static struct clk_factor_table sd_factor_table[] = { > { 12, 1, 13 }, { 13, 1, 14 }, { 14, 1, 15 }, { 15, 1, 16 }, > { 16, 1, 17 }, { 17, 1, 18 }, { 18, 1, 19 }, { 19, 1, 20 }, > { 20, 1, 21 }, { 21, 1, 22 }, { 22, 1, 23 }, { 23, 1, 24 }, > - { 24, 1, 25 }, { 25, 1, 26 }, { 26, 1, 27 }, { 27, 1, 28 }, > - { 28, 1, 29 }, { 29, 1, 30 }, { 30, 1, 31 }, { 31, 1, 32 }, > + { 24, 1, 25 }, > > /* bit8: /128 */ > { 256, 1, 1 * 128 }, { 257, 1, 2 * 128 }, { 258, 1, 3 * 128 }, { 259, 1, 4 * 128 }, > @@ -137,8 +136,7 @@ static struct clk_factor_table sd_factor_table[] = { > { 268, 1, 13 * 128 }, { 269, 1, 14 * 128 }, { 270, 1, 15 * 128 }, { 271, 1, 16 * 128 }, > { 272, 1, 17 * 128 }, { 273, 1, 18 * 128 }, { 274, 1, 19 * 128 }, { 275, 1, 20 * 128 }, > { 276, 1, 21 * 128 }, { 277, 1, 22 * 128 }, { 278, 1, 23 * 128 }, { 279, 1, 24 * 128 }, > - { 280, 1, 25 * 128 }, { 281, 1, 26 * 128 }, { 282, 1, 27 * 128 }, { 283, 1, 28 * 128 }, > - { 284, 1, 29 * 128 }, { 285, 1, 30 * 128 }, { 286, 1, 31 * 128 }, { 287, 1, 32 * 128 }, > + { 280, 1, 25 * 128 }, > { 0, 0, 0 }, > }; > > -- > 2.31.1 >