From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3AB3C48BE0 for ; Thu, 10 Jun 2021 19:23:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF55861246 for ; Thu, 10 Jun 2021 19:23:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230482AbhFJTZb (ORCPT ); Thu, 10 Jun 2021 15:25:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230284AbhFJTZY (ORCPT ); Thu, 10 Jun 2021 15:25:24 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F91BC061760 for ; Thu, 10 Jun 2021 12:23:17 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id b14so13229448iow.13 for ; Thu, 10 Jun 2021 12:23:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LSNscCRP7JfsjOWiGj3ECcyfzJq/+6gwkjgojdezt6g=; b=DDFz+TgsEfq8Q9Kx50srPZd+fk4kD9yQBXU2gcl3I1G0prMIdeRMgv1HKbUJyETaFz uYD0UUeZcTZyach78CSN1FySvlydoeUikv+Rk7dEX6jItSvMX40wEUY+DFaCelW1Ywsx My1aG94zsXXfktL1BSa9BLHw2F0nk8fpBnTNtwrlWsMhOvpBzbtBDstbpQszudxcuMAQ G6hadkwdufYzwFLyN/5T8oP/YSSx+Ah3FXoPumjvlIogRtk4d/puiTCxzKABZ48ThEnx ZIlOA4KoA3vWOrDiSSn7FaceSVv3KKanUnwLrnqQX1a0Z6LzkdyD2xOk37uOVcKn+QPn IPlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LSNscCRP7JfsjOWiGj3ECcyfzJq/+6gwkjgojdezt6g=; b=h8w5MmO6QnpViXa2UMJBdMkTJ+GfQwgGyI6FqTMxcMDFo5E7JidRC1Gde6UqCgdkp9 XEGcckdcV5ruEXwGIv5rO1rQCXbfuAIOc3yBKu6IeGWt465bH/v1LURFNJPf2Zl3idt9 rzqUZZySHPLb9lbM6Ji2vh98nfM4o673UV+3ws6v3jVPSG/MES6kIZHX20o6Lk/k/FVx gWj9rNIyGvvxwIbSalqgRB+7jfIhxYv5QO4AlZPzIw9oIrH7zxPQaCAtxycOPlRCZtzO XlmWTqWnaa+IlbnYovSMMJqL/n615s6CeJg0cNBF1hssy+YCuVzvwsAPjJWdx5p5XIjh bVlA== X-Gm-Message-State: AOAM532Fp9+5SOq8AIKu8P3chi5Xo1byXSl5+F1EHvKfFjTPLgqDspXX FycCV+yyhoBOnY2y66qgtOgMPQ== X-Google-Smtp-Source: ABdhPJxHI3Cif3aOFpJOe1jclO5muO0uhEiTRSiUKoVU3KxL/xBpD85DU02qhe7focn+I+U9rqF3lw== X-Received: by 2002:a05:6638:3393:: with SMTP id h19mr222269jav.0.1623352996717; Thu, 10 Jun 2021 12:23:16 -0700 (PDT) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id w21sm2028684iol.52.2021.06.10.12.23.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 12:23:16 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: bjorn.andersson@linaro.org, evgreen@chromium.org, cpratapa@codeaurora.org, subashab@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 4/8] net: ipa: pass mem ID to ipa_mem_zero_region_add() Date: Thu, 10 Jun 2021 14:23:04 -0500 Message-Id: <20210610192308.2739540-5-elder@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210610192308.2739540-1-elder@linaro.org> References: <20210610192308.2739540-1-elder@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pass a memory region ID rather than the address of a memory region descriptor to ipa_mem_zero_region_add() to simplify callers. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_mem.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/net/ipa/ipa_mem.c b/drivers/net/ipa/ipa_mem.c index 9e504ec278179..7df5496bdc2e4 100644 --- a/drivers/net/ipa/ipa_mem.c +++ b/drivers/net/ipa/ipa_mem.c @@ -28,9 +28,10 @@ /* Add an immediate command to a transaction that zeroes a memory region */ static void -ipa_mem_zero_region_add(struct gsi_trans *trans, const struct ipa_mem *mem) +ipa_mem_zero_region_add(struct gsi_trans *trans, enum ipa_mem_id mem_id) { struct ipa *ipa = container_of(trans->gsi, struct ipa, gsi); + const struct ipa_mem *mem = &ipa->mem[mem_id]; dma_addr_t addr = ipa->zero_addr; if (!mem->size) @@ -83,11 +84,9 @@ int ipa_mem_setup(struct ipa *ipa) ipa_cmd_hdr_init_local_add(trans, offset, size, addr); - ipa_mem_zero_region_add(trans, &ipa->mem[IPA_MEM_MODEM_PROC_CTX]); - - ipa_mem_zero_region_add(trans, &ipa->mem[IPA_MEM_AP_PROC_CTX]); - - ipa_mem_zero_region_add(trans, &ipa->mem[IPA_MEM_MODEM]); + ipa_mem_zero_region_add(trans, IPA_MEM_MODEM_PROC_CTX); + ipa_mem_zero_region_add(trans, IPA_MEM_AP_PROC_CTX); + ipa_mem_zero_region_add(trans, IPA_MEM_MODEM); gsi_trans_commit_wait(trans); @@ -411,11 +410,9 @@ int ipa_mem_zero_modem(struct ipa *ipa) return -EBUSY; } - ipa_mem_zero_region_add(trans, &ipa->mem[IPA_MEM_MODEM_HEADER]); - - ipa_mem_zero_region_add(trans, &ipa->mem[IPA_MEM_MODEM_PROC_CTX]); - - ipa_mem_zero_region_add(trans, &ipa->mem[IPA_MEM_MODEM]); + ipa_mem_zero_region_add(trans, IPA_MEM_MODEM_HEADER); + ipa_mem_zero_region_add(trans, IPA_MEM_MODEM_PROC_CTX); + ipa_mem_zero_region_add(trans, IPA_MEM_MODEM); gsi_trans_commit_wait(trans); -- 2.27.0