From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C5CDC48BD1 for ; Thu, 10 Jun 2021 21:01:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52F6161375 for ; Thu, 10 Jun 2021 21:01:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231184AbhFJVC5 (ORCPT ); Thu, 10 Jun 2021 17:02:57 -0400 Received: from linux.microsoft.com ([13.77.154.182]:59198 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbhFJVCz (ORCPT ); Thu, 10 Jun 2021 17:02:55 -0400 Received: from sequoia (162-237-133-238.lightspeed.rcsntx.sbcglobal.net [162.237.133.238]) by linux.microsoft.com (Postfix) with ESMTPSA id 10DE820B7178; Thu, 10 Jun 2021 14:00:58 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 10DE820B7178 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1623358859; bh=1gwFEPolZQHFZwTUj828RxfqMs5M/HAdxQV/Mcrv+ZY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UHNY9mBKYgSjccyLTgX+NTkRaXnIpaq95F0fA0A4p2s58w+Ww8Kp12++AuJRIZelM Zm0YtQcqJziAe4YI+rUqPVCvD/jvTVmTz659UiZeKcFNorNJGq4LDGZazICn3WjIFF sV8u7pgA6lJUbjtcOSV/BQ7qH9sCu8JECqLQpgzA= Date: Thu, 10 Jun 2021 16:00:56 -0500 From: Tyler Hicks To: Jens Wiklander Cc: Sumit Garg , Rijo-john.Thomas@amd.com, Allen Pais , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Vikas Gupta , Thirupathaiah Annapureddy , Pavel Tatashin , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , op-tee@lists.trustedfirmware.org, linux-integrity , bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH v3 5/7] tee: Support shm registration without dma-buf backing Message-ID: <20210610210056.GO4910@sequoia> References: <20210609002326.210024-1-tyhicks@linux.microsoft.com> <20210609002326.210024-6-tyhicks@linux.microsoft.com> <20210609054621.GB4910@sequoia> <20210609121533.GA2267052@jade> <20210609134225.GC4910@sequoia> <20210609135104.GD4910@sequoia> <20210610073424.GB2753553@jade> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210610073424.GB2753553@jade> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-06-10 09:34:24, Jens Wiklander wrote: > On Wed, Jun 09, 2021 at 08:51:04AM -0500, Tyler Hicks wrote: > [snip] > > > > I've just posted "[PATCH 0/7] tee: shared memory updates", > > > > https://lore.kernel.org/lkml/20210609102324.2222332-1-jens.wiklander@linaro.org/ > > > > > > > > Where tee_shm_alloc() is replaced by among other functions > > > > tee_shm_alloc_kernel_buf(). tee_shm_alloc_kernel_buf() takes care of the > > > > problem with TEE_SHM_DMA_BUF. > > > > > > Thanks! At first glance, that series would take care of the last three > > > patches in my kexec/kdump series. > > > > Correction: Your series would not completely take care of the last three > > patches in my kexec/kdump series because your series doesn't implement > > the .shutdown() hook for tee_bnxt_fw. > > > > Does it make sense to take my series first and then rebase your series > > on top of it? That would allow my fixes to flow back to stable, then > > your changes would greatly clean up the implementation in future > > releases. > > Yes, we could try that. I'd like to see tee_shm_alloc_kernel_buf() being > used instead of tee_shm_alloc() in ftpm_tee_probe() and > tee_bnxt_fw_probe(). So it would be great if you could include "tee: add > tee_shm_alloc_kernel_buf()" in your patch set. That would be no problem at all. I like that idea and I've prepared a v4 with that change. I'll send it out shortly once I've finished testing. > My patch set would then shrink a bit. By the way, thanks for reviewing > it. No problem! I feel like I'm starting to understand the TEE subsystem and OP-TEE driver a bit so I'm happy to help out. Tyler > > Cheers, > Jens >