From: Tyler Hicks <email@example.com>
To: Jens Wiklander <firstname.lastname@example.org>
Cc: "Sumit Garg" <email@example.com>,
"Allen Pais" <firstname.lastname@example.org>,
"Peter Huewe" <email@example.com>,
"Jarkko Sakkinen" <firstname.lastname@example.org>,
"Jason Gunthorpe" <email@example.com>,
"Vikas Gupta" <firstname.lastname@example.org>,
"Thirupathaiah Annapureddy" <email@example.com>,
"Pavel Tatashin" <firstname.lastname@example.org>,
"Rafał Miłecki" <email@example.com>,
"Linux Kernel Mailing List" <firstname.lastname@example.org>
Subject: Re: [PATCH v3 5/7] tee: Support shm registration without dma-buf backing
Date: Thu, 10 Jun 2021 16:05:01 -0500 [thread overview]
Message-ID: <20210610210501.GP4910@sequoia> (raw)
On 2021-06-10 09:49:48, Jens Wiklander wrote:
> On Wed, Jun 09, 2021 at 08:42:25AM -0500, Tyler Hicks wrote:
> > > I've just posted "[PATCH 0/7] tee: shared memory updates",
> > > https://email@example.com/
> > >
> > > Where tee_shm_alloc() is replaced by among other functions
> > > tee_shm_alloc_kernel_buf(). tee_shm_alloc_kernel_buf() takes care of the
> > > problem with TEE_SHM_DMA_BUF.
> > Thanks! At first glance, that series would take care of the last three
> > patches in my kexec/kdump series.
> > I'm a bit worried that it is a rewrite of the shm allocator. Do you plan
> > to send all of that to stable? (I mentioned earlier in this thread that
> > I'm affected by these bugs in linux-5.4.y.)
> No, that might be a bit much.
> > Also, you and Sumit don't seem to have the same opinion on kernel
> > drivers making use of tee_shm_register() for allocations that are only
> > used internally. Can you comment on that?
> > I'm not clear on the next steps for fixing these kexec/kdump bugs in
> > older releases. I appreciate any guidance here.
> Neither am I be honest. You're the only one that has brought up this
> problem so perhaps it's enough to focus on the stable branch you need to
> have fixed.
I've already added Fixes tags to all of my patches. If you are
comfortable with them going to stable, you'd add
'Cc: firstname.lastname@example.org' to them if/when you merge them so that the
stable team will ensure that they're applied.
Note that I'm not the only person that brought up this bug:
Once I started digging in, I realized that there were more kexec/kdump
bugs and the series grew.
> If I've understood it correctly it's best if it's possible to
> cherry-pick the fixes from mainline to the stable branch in question.
> So we must make sure to get your needed patches in before any rewrites
> that would make cherry-picking impossible. The rewrite I'm proposing
> isn't urgent so it can be held off for a while.
Thanks for holding off. I'll be quick on my revisions so that you don't
have to moth ball your series for too much longer.
next prev parent reply other threads:[~2021-06-10 21:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 0:23 [PATCH v3 0/7] tee: Improve support for kexec and kdump Tyler Hicks
2021-06-09 0:23 ` [PATCH v3 1/7] optee: Fix memory leak when failing to register shm pages Tyler Hicks
2021-06-09 0:23 ` [PATCH v3 2/7] optee: Refuse to load the driver under the kdump kernel Tyler Hicks
2021-06-09 0:23 ` [PATCH v3 3/7] optee: fix tee out of memory failure seen during kexec reboot Tyler Hicks
2021-06-09 0:23 ` [PATCH v3 4/7] optee: Clear stale cache entries during initialization Tyler Hicks
2021-06-09 0:23 ` [PATCH v3 5/7] tee: Support shm registration without dma-buf backing Tyler Hicks
2021-06-09 4:29 ` Sumit Garg
2021-06-09 5:46 ` Tyler Hicks
2021-06-09 10:52 ` Sumit Garg
2021-06-09 12:15 ` Jens Wiklander
2021-06-09 13:42 ` Tyler Hicks
2021-06-09 13:51 ` Tyler Hicks
2021-06-10 7:34 ` Jens Wiklander
2021-06-10 21:00 ` Tyler Hicks
2021-06-10 7:49 ` Jens Wiklander
2021-06-10 21:05 ` Tyler Hicks [this message]
2021-06-10 7:40 ` Allen Pais
2021-06-10 7:18 ` Jens Wiklander
2021-06-10 12:14 ` Sumit Garg
2021-06-09 0:23 ` [PATCH v3 6/7] tpm_ftpm_tee: Free and unregister dynamic shared memory during kexec Tyler Hicks
2021-06-09 0:23 ` [PATCH v3 7/7] firmware: tee_bnxt: Release shm, session, and context " Tyler Hicks
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).