From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71EC7C48BE6 for ; Fri, 11 Jun 2021 08:34:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C69961287 for ; Fri, 11 Jun 2021 08:34:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231516AbhFKIgm (ORCPT ); Fri, 11 Jun 2021 04:36:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231246AbhFKIgl (ORCPT ); Fri, 11 Jun 2021 04:36:41 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F9ACC0613A3; Fri, 11 Jun 2021 01:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Subject:Cc:To:From:Date:Message-ID: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To:References; bh=jhqe0ycYUE5W2gexDEZiW6HAUbaWg7hOOf8Y34psToY=; b=UUD2r/QHpuvuNjmNerfzyTwC5n xZP9I7W52jePJxsw3SYw+mHl7nw8lGnCl47v5JPqtTkTzVhxaKXB0WuMpv9M5fbvGKTYXLr+WhlBL E55WPGZUPo/6k5au+h9WC5eS9CbxeXRi6Ps+hiM2XzzE5cxIz+DPHzv/dFSO10sH2MlW10Mceux3V V5Kd0MpFgnntvjNC9L07SJkGwDE083P5/e8H6RvQ7DpW06e+d2P5fHs4ObVC8+pLZfDSgAFB83w// UihBTgoYtD0Y5rWF6XqNuQc8x+w41ZYwdEixCaBpLK0D0kEmkEQVO/39VHXP6StNBCPmCqKXkXGDH /zqUKGtA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lrcY0-002ZVv-JM; Fri, 11 Jun 2021 08:30:07 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id E98C73001E3; Fri, 11 Jun 2021 10:29:42 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id DCBB52BCF392F; Fri, 11 Jun 2021 10:29:42 +0200 (CEST) Message-ID: <20210611082810.970791107@infradead.org> User-Agent: quilt/0.66 Date: Fri, 11 Jun 2021 10:28:10 +0200 From: Peter Zijlstra To: Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira Cc: Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Jens Axboe , Alasdair Kergon , Mike Snitzer , "David S. Miller" , Jakub Kicinski , Felipe Balbi , Greg Kroah-Hartman , Alexander Viro , Tejun Heo , Zefan Li , Johannes Weiner , Jason Wessel , Daniel Thompson , Douglas Anderson , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "Rafael J. Wysocki" , Pavel Machek , Will Deacon , Waiman Long , Boqun Feng , Oleg Nesterov , Davidlohr Bueso , "Paul E. McKenney" , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , John Stultz , Stephen Boyd , Andrew Morton , Paolo Bonzini , Stephen Rothwell , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: [PATCH v2 0/7] Cleanup task_struct::state Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! The task_struct::state variable is a bit odd in a number of ways: - it's declared 'volatile' (against current practises); - it's 'unsigned long' which is a weird size; - it's type is inconsistent when used for function arguments. These patches clean that up by making it consistently 'unsigned int', and replace (almost) all accesses with READ_ONCE()/WRITE_ONCE(). In order to not miss any, the variable is renamed, ensuring a missed conversion results in a compile error. The first few patches fix a number of pre-existing errors and introduce a few helpers to make the final conversion less painful. This series applies on top of tip/master, and has been having the all-clear from the robots for the past week. Since v1: - fixed a whole bunch of compile fail on !x86 - collected tags - (slightly) smaller Cc list The plan is to stick them in tip/sched/core early next week, I'm hoping this won't cause too much pain for sfr.