From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Joe Perches <joe@perches.com>, Stephen Boyd <swboyd@chromium.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: [PATCH 9/9] nvmem: qfprom: Improve the comment about regulator setting
Date: Fri, 11 Jun 2021 09:33:48 +0100 [thread overview]
Message-ID: <20210611083348.20170-10-srinivas.kandagatla@linaro.org> (raw)
In-Reply-To: <20210611083348.20170-1-srinivas.kandagatla@linaro.org>
From: Douglas Anderson <dianders@chromium.org>
In review feedback Joe Perches found the existing comment
confusing. Let's use something based on the wording proposed by Joe.
Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
drivers/nvmem/qfprom.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
index 1ba666bcb900..81fbad5e939d 100644
--- a/drivers/nvmem/qfprom.c
+++ b/drivers/nvmem/qfprom.c
@@ -196,9 +196,9 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
}
/*
- * Hardware requires a min voltage for fuse blowing; this may be
- * a rail shared do don't specify a max--regulator constraints
- * will handle.
+ * Hardware requires a minimum voltage for fuse blowing.
+ * This may be a shared rail so don't specify a maximum.
+ * Regulator constraints will cap to the actual maximum.
*/
ret = regulator_set_voltage(priv->vcc, qfprom_blow_uV, INT_MAX);
if (ret) {
--
2.21.0
next prev parent reply other threads:[~2021-06-11 8:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 8:33 [PATCH 0/9] nvmem: patches (set 1) for 5.14 Srinivas Kandagatla
2021-06-11 8:33 ` [PATCH 1/9] nvmem: sprd: Add missing MODULE_DEVICE_TABLE Srinivas Kandagatla
2021-06-11 8:55 ` Greg KH
2021-06-11 9:09 ` Srinivas Kandagatla
2021-06-11 8:33 ` [PATCH 2/9] nvmem: qcom-spmi-sdam: add " Srinivas Kandagatla
2021-06-11 8:55 ` Greg KH
2021-06-11 8:33 ` [PATCH 3/9] nvmem: sc27xx: Add " Srinivas Kandagatla
2021-06-11 8:55 ` Greg KH
2021-06-11 8:33 ` [PATCH 4/9] nvmem: sprd: Fix an error message Srinivas Kandagatla
2021-06-11 8:56 ` Greg KH
2021-06-11 9:05 ` Srinivas Kandagatla
2021-06-11 9:17 ` Greg KH
2021-06-11 9:45 ` Greg KH
2021-06-11 9:48 ` Greg KH
2021-06-11 10:17 ` Srinivas Kandagatla
2021-06-11 10:09 ` Srinivas Kandagatla
2021-06-11 10:10 ` Marion & Christophe JAILLET
2021-06-11 10:17 ` Greg KH
2021-06-11 10:20 ` Srinivas Kandagatla
2021-06-11 8:33 ` [PATCH 5/9] nvmem: core: add a missing of_node_put Srinivas Kandagatla
2021-06-11 8:57 ` Greg KH
2021-06-11 9:10 ` Srinivas Kandagatla
2021-06-11 8:33 ` [PATCH 6/9] nvmem: sunxi_sid: Set type to OTP Srinivas Kandagatla
2021-06-11 8:33 ` [PATCH 7/9] nvmem: qfprom: minor nit fixes Srinivas Kandagatla
2021-06-11 8:33 ` [PATCH 8/9] nvmem: core: constify nvmem_cell_read_variable_common() return value Srinivas Kandagatla
2021-06-11 8:33 ` Srinivas Kandagatla [this message]
2021-06-11 8:58 ` [PATCH 0/9] nvmem: patches (set 1) for 5.14 Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210611083348.20170-10-srinivas.kandagatla@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).