From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] PM: domains: call mutex_destroy when removing the genpd
Date: Fri, 11 Jun 2021 13:15:39 +0300 [thread overview]
Message-ID: <20210611101540.3379937-2-dmitry.baryshkov@linaro.org> (raw)
In-Reply-To: <20210611101540.3379937-1-dmitry.baryshkov@linaro.org>
It is a good practice to destroy mutexes with mutex_destroy, so call
this function for releasing genpd->mlock.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/base/power/domain.c | 25 ++++++++++++++++++++-----
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index b6a782c31613..74219d032910 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1910,6 +1910,11 @@ static void genpd_lock_init(struct generic_pm_domain *genpd)
}
}
+static void genpd_lock_destroy(struct generic_pm_domain *genpd) {
+ if (!(genpd->flags & GENPD_FLAG_IRQ_SAFE))
+ mutex_destroy(&genpd->mlock);
+}
+
/**
* pm_genpd_init - Initialize a generic I/O PM domain object.
* @genpd: PM domain object to initialize.
@@ -1960,12 +1965,16 @@ int pm_genpd_init(struct generic_pm_domain *genpd,
/* Always-on domains must be powered on at initialization. */
if ((genpd_is_always_on(genpd) || genpd_is_rpm_always_on(genpd)) &&
- !genpd_status_on(genpd))
- return -EINVAL;
+ !genpd_status_on(genpd)) {
+ ret = -EINVAL;
+ goto fail;
+ }
if (genpd_is_cpu_domain(genpd) &&
- !zalloc_cpumask_var(&genpd->cpus, GFP_KERNEL))
- return -ENOMEM;
+ !zalloc_cpumask_var(&genpd->cpus, GFP_KERNEL)) {
+ ret = -ENOMEM;
+ goto fail;
+ }
/* Use only one "off" state if there were no states declared */
if (genpd->state_count == 0) {
@@ -1973,7 +1982,7 @@ int pm_genpd_init(struct generic_pm_domain *genpd,
if (ret) {
if (genpd_is_cpu_domain(genpd))
free_cpumask_var(genpd->cpus);
- return ret;
+ goto fail;
}
} else if (!gov && genpd->state_count > 1) {
pr_warn("%s: no governor for states\n", genpd->name);
@@ -1988,6 +1997,11 @@ int pm_genpd_init(struct generic_pm_domain *genpd,
mutex_unlock(&gpd_list_lock);
return 0;
+
+fail:
+ genpd_lock_destroy(genpd);
+
+ return ret;
}
EXPORT_SYMBOL_GPL(pm_genpd_init);
@@ -2026,6 +2040,7 @@ static int genpd_remove(struct generic_pm_domain *genpd)
free_cpumask_var(genpd->cpus);
if (genpd->free_states)
genpd->free_states(genpd->states, genpd->state_count);
+ genpd_lock_destroy(genpd);
pr_debug("%s: removed %s\n", __func__, genpd->name);
--
2.30.2
next prev parent reply other threads:[~2021-06-11 10:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 10:15 [PATCH 0/2] PM: domains: use separate lockdep class for each genpd Dmitry Baryshkov
2021-06-11 10:15 ` Dmitry Baryshkov [this message]
2021-06-15 13:51 ` [PATCH 1/2] PM: domains: call mutex_destroy when removing the genpd Greg Kroah-Hartman
2021-06-11 10:15 ` [PATCH 2/2] PM: domain: use per-genpd lockdep class Dmitry Baryshkov
2021-06-11 13:49 ` Ulf Hansson
2021-06-11 14:34 ` Dmitry Baryshkov
2021-06-15 10:17 ` Ulf Hansson
2021-06-15 11:10 ` Mark Brown
2021-06-15 14:55 ` Ulf Hansson
2021-06-15 15:26 ` Mark Brown
2021-06-15 15:35 ` Ulf Hansson
2021-06-15 15:38 ` Mark Brown
2021-06-15 15:55 ` Bjorn Andersson
2021-06-17 9:07 ` Ulf Hansson
2021-06-17 16:19 ` Dmitry Baryshkov
2021-06-17 17:27 ` Bjorn Andersson
2021-06-17 17:17 ` Bjorn Andersson
2021-06-28 19:55 ` Dmitry Baryshkov
2021-06-29 11:05 ` Ulf Hansson
2021-06-29 15:09 ` Bjorn Andersson
2021-07-01 10:06 ` Ulf Hansson
2021-07-01 11:01 ` Dmitry Baryshkov
2021-07-01 15:14 ` Ulf Hansson
2021-06-20 0:39 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210611101540.3379937-2-dmitry.baryshkov@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).