From: Maximilian Heyne <mheyne@amazon.de>
To: SeongJae Park <sj38.park@gmail.com>
Cc: <akpm@linux-foundation.org>, SeongJae Park <sjpark@amazon.de>,
<Jonathan.Cameron@Huawei.com>, <acme@kernel.org>,
<alexander.shishkin@linux.intel.com>, <amit@kernel.org>,
<benh@kernel.crashing.org>, <brendanhiggins@google.com>,
<corbet@lwn.net>, <david@redhat.com>, <dwmw@amazon.com>,
<elver@google.com>, <fan.du@intel.com>, <foersleo@amazon.de>,
<greg@kroah.com>, <gthelen@google.com>,
<guoju.fgj@alibaba-inc.com>, <mgorman@suse.de>,
<minchan@kernel.org>, <mingo@redhat.com>, <namhyung@kernel.org>,
<peterz@infradead.org>, <riel@surriel.com>, <rientjes@google.com>,
<rostedt@goodmis.org>, <rppt@kernel.org>, <shakeelb@google.com>,
<shuah@kernel.org>, <snu@amazon.de>, <vbabka@suse.cz>,
<vdavydov.dev@gmail.com>, <zgf574564920@gmail.com>,
<linux-damon@amazon.com>, <linux-mm@kvack.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v29 12/13] mm/damon: Add user space selftests
Date: Fri, 11 Jun 2021 13:57:37 +0000 [thread overview]
Message-ID: <20210611135737.104838-1-mheyne@amazon.de> (raw)
In-Reply-To: <20210520075629.4332-13-sj38.park@gmail.com>
On Thu, 20 May 2021 07:56:28 +0000 SeongJae Park <sj38.park@gmail.com> wrote:
> From: SeongJae Park <sjpark@amazon.de>
>
> This commit adds a simple user space tests for DAMON. The tests are
> using kselftest framework.
>
> Signed-off-by: SeongJae Park <sjpark@amazon.de>
> ---
> tools/testing/selftests/damon/Makefile | 7 ++
> .../selftests/damon/_chk_dependency.sh | 28 ++++++
> .../testing/selftests/damon/debugfs_attrs.sh | 98 +++++++++++++++++++
> 3 files changed, 133 insertions(+)
> create mode 100644 tools/testing/selftests/damon/Makefile
> create mode 100644 tools/testing/selftests/damon/_chk_dependency.sh
> create mode 100755 tools/testing/selftests/damon/debugfs_attrs.sh
>
> diff --git a/tools/testing/selftests/damon/Makefile b/tools/testing/selftests/damon/Makefile
> new file mode 100644
> index 000000000000..8a3f2cd9fec0
> --- /dev/null
> +++ b/tools/testing/selftests/damon/Makefile
> @@ -0,0 +1,7 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Makefile for damon selftests
> +
> +TEST_FILES = _chk_dependency.sh
> +TEST_PROGS = debugfs_attrs.sh
> +
> +include ../lib.mk
> diff --git a/tools/testing/selftests/damon/_chk_dependency.sh b/tools/testing/selftests/damon/_chk_dependency.sh
> new file mode 100644
> index 000000000000..e090836c2bf7
> --- /dev/null
> +++ b/tools/testing/selftests/damon/_chk_dependency.sh
> @@ -0,0 +1,28 @@
> +#!/bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +
> +# Kselftest framework requirement - SKIP code is 4.
> +ksft_skip=4
> +
> +DBGFS=/sys/kernel/debug/damon
> +
> +if [ $EUID -ne 0 ];
> +then
> + echo "Run as root"
> + exit $ksft_skip
> +fi
> +
> +if [ ! -d $DBGFS ]
> +then
> + echo "$DBGFS not found"
> + exit $ksft_skip
> +fi
> +
> +for f in attrs target_ids monitor_on
> +do
> + if [ ! -f "$DBGFS/$f" ]
> + then
> + echo "$f not found"
> + exit 1
> + fi
> +done
> diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh
> new file mode 100755
> index 000000000000..4a8ab4910ee4
> --- /dev/null
> +++ b/tools/testing/selftests/damon/debugfs_attrs.sh
> @@ -0,0 +1,98 @@
> +#!/bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +
> +source ./_chk_dependency.sh
> +
> +# Test attrs file
> +file="$DBGFS/attrs"
> +
> +ORIG_CONTENT=$(cat $file)
Missing quotes around $file. Can you run shellcheck on this code and fix all
reportings, please?
> +
> +echo 1 2 3 4 5 > $file
> +if [ $? -ne 0 ]
> +then
> + echo "$file write failed"
> + echo $ORIG_CONTENT > $file
> + exit 1
> +fi
> +
> +echo 1 2 3 4 > $file
> +if [ $? -eq 0 ]
> +then
> + echo "$file write success (should failed)"
> + echo $ORIG_CONTENT > $file
> + exit 1
> +fi
> +
> +CONTENT=$(cat $file)
> +if [ "$CONTENT" != "1 2 3 4 5" ]
> +then
> + echo "$file not written"
> + echo $ORIG_CONTENT > $file
> + exit 1
> +fi
I'd add test cases for the contents written to the attrs, like checking that
input min_nr_regions is actually smaller than the input max_nr_regions values.
> +
> +echo $ORIG_CONTENT > $file
> +
> +# Test target_ids file
> +file="$DBGFS/target_ids"
> +
> +ORIG_CONTENT=$(cat $file)
> +
> +echo "1 2 3 4" > $file
> +if [ $? -ne 0 ]
> +then
> + echo "$file write fail"
> + echo $ORIG_CONTENT > $file
> + exit 1
> +fi
> +
> +echo "1 2 abc 4" > $file
> +if [ $? -ne 0 ]
> +then
> + echo "$file write fail"
> + echo $ORIG_CONTENT > $file
> + exit 1
> +fi
I've seen this construct more than once. Any chance to refactor this code? Or is
this selftest not expected to grow in the future?
> +
> +CONTENT=$(cat $file)
> +if [ "$CONTENT" != "1 2" ]
> +then
> + echo "$file not written"
> + echo $ORIG_CONTENT > $file
> + exit 1
> +fi
> +
> +echo abc 2 3 > $file
> +if [ $? -ne 0 ]
> +then
> + echo "$file wrong value write fail"
> + echo $ORIG_CONTENT > $file
> + exit 1
> +fi
> +
> +if [ ! -z "$(cat $file)" ]
> +then
> + echo "$file not cleared"
> + echo $ORIG_CONTENT > $file
> + exit 1
> +fi
> +
> +echo > $file
> +if [ $? -ne 0 ]
> +then
> + echo "$file init fail"
> + echo $ORIG_CONTENT > $file
> + exit 1
> +fi
> +
> +if [ ! -z "$(cat $file)" ]
> +then
> + echo "$file not initialized"
> + echo $ORIG_CONTENT > $file
> + exit 1
> +fi
> +
> +echo $ORIG_CONTENT > $file
> +
> +echo "PASS"
> --
> 2.17.1
>
>
>
>
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
next prev parent reply other threads:[~2021-06-11 13:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 7:56 [PATCH v29 00/13] Introduce Data Access MONitor (DAMON) SeongJae Park
2021-05-20 7:56 ` [PATCH v29 01/13] mm: " SeongJae Park
2021-05-20 7:56 ` [PATCH v29 02/13] mm/damon/core: Implement region-based sampling SeongJae Park
2021-05-20 7:56 ` [PATCH v29 03/13] mm/damon: Adaptively adjust regions SeongJae Park
2021-05-25 15:17 ` sieberf
2021-05-25 15:39 ` SeongJae Park
2021-05-20 7:56 ` [PATCH v29 04/13] mm/idle_page_tracking: Make PG_idle reusable SeongJae Park
2021-06-11 12:55 ` Shah, Amit
2021-06-11 13:49 ` SeongJae Park
2021-05-20 7:56 ` [PATCH v29 05/13] mm/damon: Implement primitives for the virtual memory address spaces SeongJae Park
2021-05-25 15:19 ` sieberf
2021-05-25 15:44 ` SeongJae Park
2021-05-20 7:56 ` [PATCH v29 06/13] mm/damon: Add a tracepoint SeongJae Park
2021-05-20 7:56 ` [PATCH v29 07/13] mm/damon: Implement a debugfs-based user space interface SeongJae Park
2021-06-11 18:59 ` sieberf
2021-06-14 6:48 ` SeongJae Park
2021-05-20 7:56 ` [PATCH v29 08/13] mm/damon/dbgfs: Export kdamond pid to the user space SeongJae Park
2021-05-20 7:56 ` [PATCH v29 09/13] mm/damon/dbgfs: Support multiple contexts SeongJae Park
2021-06-14 9:30 ` sieberf
2021-06-14 9:35 ` SeongJae Park
2021-06-14 9:44 ` Greg KH
2021-05-20 7:56 ` [PATCH v29 10/13] Documentation: Add documents for DAMON SeongJae Park
2021-06-09 7:03 ` SeongJae Park
2021-06-11 17:44 ` Boehme, Markus
2021-06-11 18:53 ` SeongJae Park
2021-05-20 7:56 ` [PATCH v29 11/13] mm/damon: Add kunit tests SeongJae Park
2021-05-20 7:56 ` [PATCH v29 12/13] mm/damon: Add user space selftests SeongJae Park
2021-06-11 13:57 ` Maximilian Heyne [this message]
2021-06-11 14:04 ` SeongJae Park
2021-05-20 7:56 ` [PATCH v29 13/13] MAINTAINERS: Update for DAMON SeongJae Park
2021-05-20 22:34 ` [PATCH v29 00/13] Introduce Data Access MONitor (DAMON) Andrew Morton
2021-05-21 2:53 ` Shakeel Butt
2021-05-21 8:55 ` Shah, Amit
2021-06-14 8:09 ` sieberf
2021-06-15 16:30 ` sieberf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210611135737.104838-1-mheyne@amazon.de \
--to=mheyne@amazon.de \
--cc=Jonathan.Cameron@Huawei.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=amit@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=dwmw@amazon.com \
--cc=elver@google.com \
--cc=fan.du@intel.com \
--cc=foersleo@amazon.de \
--cc=greg@kroah.com \
--cc=gthelen@google.com \
--cc=guoju.fgj@alibaba-inc.com \
--cc=linux-damon@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
--cc=snu@amazon.de \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=zgf574564920@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).