From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0C05C48BE0 for ; Fri, 11 Jun 2021 19:40:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CAAD1613D3 for ; Fri, 11 Jun 2021 19:40:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230385AbhFKTmX (ORCPT ); Fri, 11 Jun 2021 15:42:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:54214 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbhFKTmV (ORCPT ); Fri, 11 Jun 2021 15:42:21 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF561613CA; Fri, 11 Jun 2021 19:40:22 +0000 (UTC) Date: Fri, 11 Jun 2021 15:40:21 -0400 From: Steven Rostedt To: "Naveen N. Rao" Cc: Masami Hiramatsu , "Aneesh Kumar K.V" , linux-kernel@vger.kernel.org, Peter Zijlstra Subject: Re: [PATCH] kprobes: Print an error if probe is rejected Message-ID: <20210611154021.008537b0@gandalf.local.home> In-Reply-To: <1623419180.o4u5xf72jm.naveen@linux.ibm.com> References: <20210610085617.1590138-1-naveen.n.rao@linux.vnet.ibm.com> <20210610191643.d24e7d56d102567070fe8386@kernel.org> <1623419180.o4u5xf72jm.naveen@linux.ibm.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Jun 2021 19:25:38 +0530 "Naveen N. Rao" wrote: > We also have perf_event_open() as an interface to add probes, and I > don't think it would be helpful to require all tools to utilize the > error log from tracefs for this purpose. The there should be a perf interface to read the errors. I agree with Masami. Let's not have console logs for probe errors. -- Steve