From: Vladimir Oltean <olteanv@gmail.com>
To: Matthew Hagan <mnhagan88@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
soc@kernel.org, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Geert Uytterhoeven <geert+renesas@glider.be>,
Krzysztof Kozlowski <krzk@kernel.org>,
Sam Ravnborg <sam@ravnborg.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/5] dt-bindings: arm: bcm: NSP: add Meraki MX64/MX65
Date: Sat, 12 Jun 2021 18:07:55 +0300 [thread overview]
Message-ID: <20210612150755.efb5hw3xujkkh2va@skbuf> (raw)
In-Reply-To: <f0af3f0a-ab13-ecdc-d834-c95ddcb52866@gmail.com>
On Sat, Jun 12, 2021 at 10:21:31AM +0100, Matthew Hagan wrote:
> Hi Vladimir,
>
> Many thanks for taking the time to review the submission.
>
> On 11/06/2021 20:46, Vladimir Oltean wrote:
>
> > On Fri, Jun 11, 2021 at 12:27:13AM +0100, Matthew Hagan wrote:
> >> Add bindings for the Meraki MX64/MX65 series. Note this patch should be
> >> applied on top of "dt-bindings: arm: bcm: add NSP devices to SoCs".
> >>
> >> Signed-off-by: Matthew Hagan <mnhagan88@gmail.com>
> >> ---
> >> Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml
> >> index 78dfa315f3d0..7d184ba7d180 100644
> >> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml
> >> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml
> >> @@ -62,6 +62,12 @@ properties:
> >> - enum:
> >> - brcm,bcm958625hr
> >> - brcm,bcm958625k
> >> + - meraki,mx64
> >> + - meraki,mx64-a0
> >> + - meraki,mx64w
> >> + - meraki,mx64w-a0
> >> + - meraki,mx65
> >> + - meraki,mx65w
> >> - const: brcm,bcm58625
> >> - const: brcm,nsp
> >>
> >> --
> >> 2.26.3
> >>
> > I think these compatibles describe SoCs, whereas Meraki MX64/MX65 are
> > boards, so this is a miscategorization. Can you not just describe the
> > Northstar Plus SoC that you are using in your compatible string?
>
> My understanding is that the bcm958625hr and bcm958625k are dev boards
> using the BCM58625 SoC variant of NSP. For reference, a close example
> can be found in brcm,bcm4708.yaml in the same directory:
>
> - description: BCM53012 based boards
> items:
> - enum:
> - brcm,bcm953012er
> - brcm,bcm953012hr
> - brcm,bcm953012k
> - meraki,mr32
> - const: brcm,brcm53012
> - const: brcm,brcm53016
> - const: brcm,bcm4708
>
> For the compatible string we would definitely need to specify a unique
> device name for identification by the OS, rather than just the SoC.
>
> Of course I could be mistaken. Will await confirmation on this.
Yeah, ok, fair, after rechecking I think you're right. I'm dropping this charge.
next prev parent reply other threads:[~2021-06-12 15:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 23:27 [PATCH v2 0/5] ARM: dts: NSP: add Meraki MX64/MX65 Matthew Hagan
2021-06-10 23:27 ` [PATCH v2 1/5] dt-bindings: arm: bcm: " Matthew Hagan
2021-06-11 19:46 ` Vladimir Oltean
2021-06-12 9:21 ` Matthew Hagan
2021-06-12 15:07 ` Vladimir Oltean [this message]
2021-06-10 23:27 ` [PATCH v2 2/5] ARM: dts: NSP: Add Meraki MX64/MX65 to Makefile Matthew Hagan
2021-06-11 20:24 ` Vladimir Oltean
2021-06-12 9:23 ` Matthew Hagan
2021-06-10 23:27 ` [PATCH v2 3/5] ARM: dts: NSP: Add common bindings for MX64/MX65 Matthew Hagan
2021-06-11 20:30 ` Vladimir Oltean
2021-06-12 23:14 ` Matthew Hagan
2021-06-13 2:03 ` Florian Fainelli
2021-06-10 23:27 ` [PATCH v2 4/5] ARM: dts: NSP: Add DT files for Meraki MX64 series Matthew Hagan
2021-06-10 23:27 ` [PATCH v2 5/5] ARM: dts: NSP: Add DT files for Meraki MX65 series Matthew Hagan
2021-06-11 19:02 ` Matthew Hagan
2021-06-11 20:48 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210612150755.efb5hw3xujkkh2va@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mnhagan88@gmail.com \
--cc=olof@lixom.net \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sbranden@broadcom.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).