From: Will Deacon <will@kernel.org>
To: Dong Aisheng <aisheng.dong@nxp.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, dongas86@gmail.com,
linux-arm-kernel@lists.infradead.org,
Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
catalin.marinas@arm.com
Subject: Re: [PATCH 1/1] dma: coherent: check no-map property for arm64
Date: Mon, 14 Jun 2021 09:36:10 +0100 [thread overview]
Message-ID: <20210614083609.GA18701@willie-the-truck> (raw)
In-Reply-To: <20210611131056.3731084-1-aisheng.dong@nxp.com>
[+Catalin]
On Fri, Jun 11, 2021 at 09:10:56PM +0800, Dong Aisheng wrote:
> Coherent dma on ARM64 also can't work with mapped system ram,
> that means 'no-map' property must be specified in dts.
> Add the missing check for ARM64 platforms as well.
> Besides 'no-map' checking, 'linux,dma-default' feature is also
> enabled for ARM64 along with this patch.
Please can you explain _why_ it can't work? We don't need to tear down
aliases from the linear map for the streaming DMA API, so why is this
case different? Also, coherent devices wouldn't need this either way,
would they? What problem are you solving here?
Thanks,
Will
>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> kernel/dma/coherent.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/dma/coherent.c b/kernel/dma/coherent.c
> index 5b5b6c7ec7f2..d1831da7afba 100644
> --- a/kernel/dma/coherent.c
> +++ b/kernel/dma/coherent.c
> @@ -356,7 +356,7 @@ static int __init rmem_dma_setup(struct reserved_mem *rmem)
> if (of_get_flat_dt_prop(node, "reusable", NULL))
> return -EINVAL;
>
> -#ifdef CONFIG_ARM
> +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64)
> if (!of_get_flat_dt_prop(node, "no-map", NULL)) {
> pr_err("Reserved memory: regions without no-map are not yet supported\n");
> return -EINVAL;
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-06-14 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 13:10 [PATCH 1/1] dma: coherent: check no-map property for arm64 Dong Aisheng
2021-06-14 8:36 ` Will Deacon [this message]
2021-06-14 10:07 ` Dong Aisheng
2021-06-14 14:51 ` Catalin Marinas
2021-06-14 15:34 ` Robin Murphy
2021-06-14 15:36 ` Christoph Hellwig
2021-06-15 7:19 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614083609.GA18701@willie-the-truck \
--to=will@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=catalin.marinas@arm.com \
--cc=dongas86@gmail.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).