From: Viresh Kumar <viresh.kumar@linaro.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
"Viresh Kumar" <vireshk@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Bill Mills" <bill.mills@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Stratos Mailing List" <stratos-dev@op-lists.linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Stefano Garzarella --cc virtualization @ lists .
linux-foundation . org" <sgarzare@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH V3 1/3] gpio: Add virtio-gpio driver
Date: Mon, 14 Jun 2021 15:51:19 +0530 [thread overview]
Message-ID: <20210614102119.qifm5sj7fpg54iqo@vireshk-i7> (raw)
In-Reply-To: <CAK8P3a11YhcEOjauWc872BQv+SO-E5+gnz7Lk6UK42iVw7Oyfg@mail.gmail.com>
On 10-06-21, 15:22, Arnd Bergmann wrote:
> Can you give an example of how this would be hooked up to other drivers
> using those gpios. Can you give an example of how using the "gpio-keys" or
> "gpio-leds" drivers in combination with virtio-gpio looks like in the DT?
>
> Would qemu simply add the required DT properties to the device node that
> corresponds to the virtio device in this case?
>
> From what I can tell, both the mmio and pci variants of virtio can have their
> dev->of_node populated, but I don't see the logic in register_virtio_device()
> that looks up the of_node of the virtio_device that the of_gpio code then
> tries to refer to.
To be honest, I haven't tried this yet and I was expecting it to be
already taken care of. I was relying on the DTB automatically
generated by Qemu to get the driver probed and didn't have a look at
it as well.
I now understand that it won't be that straight forward. The same must
be true for adding an i2c device to an i2c bus over virtio (The way I
tested that earlier was by using the sysfs file to add a device to a
bus).
This may be something lacking generally for virtio-pci thing, not
sure though.
--
viresh
next prev parent reply other threads:[~2021-06-14 10:21 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 12:09 [PATCH V3 0/3] gpio: Add virtio based driver Viresh Kumar
2021-06-10 12:16 ` [PATCH V3 1/3] gpio: Add virtio-gpio driver Viresh Kumar
2021-06-10 13:22 ` Arnd Bergmann
2021-06-10 16:00 ` Enrico Weigelt, metux IT consult
[not found] ` <01000179f6a7715c-cd106846-7770-4088-bb7c-a696bfcbf83e-000000@email.amazonses.com>
2021-06-10 17:03 ` [Stratos-dev] " Jean-Philippe Brucker
2021-06-10 19:41 ` Arnd Bergmann
2021-06-14 10:21 ` Viresh Kumar [this message]
2021-06-14 12:31 ` Arnd Bergmann
2021-06-14 12:49 ` Vincent Guittot
[not found] ` <0100017a0a9264cc-57668c56-fdbf-412a-9f82-9bf95f5c653e-000000@email.amazonses.com>
2021-06-14 12:58 ` [Stratos-dev] " Arnd Bergmann
2021-06-14 13:24 ` Vincent Guittot
2021-06-14 20:54 ` Arnd Bergmann
2021-06-15 7:30 ` Vincent Guittot
2021-06-10 15:54 ` Enrico Weigelt, metux IT consult
2021-06-10 16:57 ` Viresh Kumar
2021-06-10 20:46 ` Linus Walleij
2021-06-11 3:56 ` Viresh Kumar
2021-06-11 7:42 ` Geert Uytterhoeven
2021-06-11 8:01 ` Viresh Kumar
2021-06-11 8:22 ` Geert Uytterhoeven
2021-06-15 11:15 ` Viresh Kumar
2021-06-15 11:37 ` Geert Uytterhoeven
2021-06-15 20:03 ` Linus Walleij
2021-06-16 1:45 ` Viresh Kumar
2021-06-14 8:07 ` Enrico Weigelt, metux IT consult
2021-06-14 8:12 ` Andy Shevchenko
2021-06-14 9:14 ` Viresh Kumar
2021-06-14 9:17 ` Enrico Weigelt, metux IT consult
2021-06-14 9:52 ` Viresh Kumar
2021-06-14 9:12 ` Viresh Kumar
2021-06-14 9:29 ` Enrico Weigelt, metux IT consult
2021-06-14 8:03 ` Enrico Weigelt, metux IT consult
2021-06-14 9:24 ` Viresh Kumar
2021-06-16 3:30 ` Bjorn Andersson
2021-06-16 15:52 ` Enrico Weigelt, metux IT consult
2021-06-18 9:13 ` Linus Walleij
2021-06-21 17:25 ` Bjorn Andersson
2021-06-10 12:16 ` [PATCH V3 2/3] gpio: virtio: Add IRQ support Viresh Kumar
2021-06-10 21:30 ` Linus Walleij
2021-06-14 7:08 ` Viresh Kumar
2021-06-10 12:16 ` [PATCH V3 3/3] MAINTAINERS: Add entry for Virtio-gpio Viresh Kumar
[not found] ` <01000179f5da7763-2ea817c6-e176-423a-952e-de02443f71e2-000000@email.amazonses.com>
2021-06-10 17:40 ` [PATCH V3 1/3] gpio: Add virtio-gpio driver Jean-Philippe Brucker
2021-06-11 3:39 ` Viresh Kumar
[not found] ` <01000179f9276678-ae2bb25f-4c0c-4176-b906-650c585b9753-000000@email.amazonses.com>
2021-06-11 8:34 ` [Stratos-dev] " Arnd Bergmann
2021-06-14 5:26 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614102119.qifm5sj7fpg54iqo@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=arnd@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=bill.mills@linaro.org \
--cc=info@metux.net \
--cc=jasowang@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=stratos-dev@op-lists.linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).