From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6C49C48BDF for ; Tue, 15 Jun 2021 10:41:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FB0761417 for ; Tue, 15 Jun 2021 10:41:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231702AbhFOKnP (ORCPT ); Tue, 15 Jun 2021 06:43:15 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:48812 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231686AbhFOKnK (ORCPT ); Tue, 15 Jun 2021 06:43:10 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1623753666; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=vDtGoG4ESr3xkYa9OGgjFSeF8fMq4d5QmvhAIKTqziQ=; b=r2K+XkgX3f8zmT3XookGSRSmuP97a4VHR8pR3oESXNcOg78pppVOWMk78ndOqtNiCJ2nSmU1 WOG7mZtYDIP1otF7UtDVeg/a1IiVzSrn2iT2zCqNgBJmRxjkR1boV8F7F4bUQMc3u8OK3cYA OWbgOym/jyjDq4cV+uPa7KK2j3g= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 60c883a9e27c0cc77f281348 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 15 Jun 2021 10:40:41 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id F10DEC43217; Tue, 15 Jun 2021 10:40:40 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 426AAC433F1; Tue, 15 Jun 2021 10:40:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 426AAC433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: brcmsmac: improve readability on addresses copy From: Kalle Valo In-Reply-To: <20210511070257.7843-1-ihuguet@redhat.com> References: <20210511070257.7843-1-ihuguet@redhat.com> To: =?utf-8?b?w43DsWlnbyBIdWd1ZXQ=?= Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210615104040.F10DEC43217@smtp.codeaurora.org> Date: Tue, 15 Jun 2021 10:40:40 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Íñigo Huguet wrote: > A static analyzer identified as a potential bug the copy of > 12 bytes from a 6 bytes array to a 6 bytes array. Both > arrays are 6 bytes addresses. > > Although not being a real bug, it is not immediately clear > why is done this way: next 6 bytes address, contiguous to > the first one, must also be copied to next contiguous 6 bytes > address of the destination. > > Copying each one separately will make both static analyzers > and reviewers happier. > > Signed-off-by: Íñigo Huguet Patch applied to wireless-drivers-next.git, thanks. c0277e25d28f brcmsmac: improve readability on addresses copy -- https://patchwork.kernel.org/project/linux-wireless/patch/20210511070257.7843-1-ihuguet@redhat.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches