From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0991C48BDF for ; Tue, 15 Jun 2021 10:43:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A374B6115B for ; Tue, 15 Jun 2021 10:43:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231499AbhFOKpD (ORCPT ); Tue, 15 Jun 2021 06:45:03 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:48812 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231327AbhFOKpC (ORCPT ); Tue, 15 Jun 2021 06:45:02 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1623753778; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=26jUmp4vDfJYFJ+Qjl7Y8g8Lair1pch9T7baqcUuAJ4=; b=JuAytaaGwyD8m2xFezCRts0WrIdb8bA+bMDq8O/AgT5oDk55rhjz6rG3AHtoCWNZVEXw456P Q3DeLx5K98ZgnLpbhxrGrZXgZ3Jz4ffWhsYJkfcZ2mZW7uDP83KcryW0EUpeiO/VJ2gQr9jj n1ii0BZMy7l5TJY0hF3LsVY0djQ= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 60c88420b6ccaab753a548fb (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 15 Jun 2021 10:42:40 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 57EF3C433F1; Tue, 15 Jun 2021 10:42:40 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id CC250C433F1; Tue, 15 Jun 2021 10:42:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CC250C433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: brcmsmac: Drop unnecessary NULL check after container_of From: Kalle Valo In-Reply-To: <20210511235629.1686038-1-linux@roeck-us.net> References: <20210511235629.1686038-1-linux@roeck-us.net> To: Guenter Roeck Cc: Arend van Spriel , "David S . Miller" , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210615104240.57EF3C433F1@smtp.codeaurora.org> Date: Tue, 15 Jun 2021 10:42:40 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Guenter Roeck wrote: > The parameter passed to ai_detach() is guaranteed to never be NULL > because it is checked by the caller. Consequently, the result of > container_of() on it is also never NULL, and a NULL check on it > is unnecessary. Even without that, the NULL check would still be > unnecessary because the subsequent kfree() can handle NULL arguments. > On top of all that, it is misleading to check the result of container_of() > against NULL because the position of the contained element could change, > which would make the check invalid. Remove it. > > This change was made automatically with the following Coccinelle script. > > @@ > type t; > identifier v; > statement s; > @@ > > <+... > ( > t v = container_of(...); > | > v = container_of(...); > ) > ... > when != v > - if (\( !v \| v == NULL \) ) s > ...+> > > Signed-off-by: Guenter Roeck Patch applied to wireless-drivers-next.git, thanks. 34fe7038a3b3 brcmsmac: Drop unnecessary NULL check after container_of -- https://patchwork.kernel.org/project/linux-wireless/patch/20210511235629.1686038-1-linux@roeck-us.net/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches