From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10B24C48BE5 for ; Tue, 15 Jun 2021 16:38:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F157B617ED for ; Tue, 15 Jun 2021 16:38:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230487AbhFOQkE (ORCPT ); Tue, 15 Jun 2021 12:40:04 -0400 Received: from verein.lst.de ([213.95.11.211]:50334 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230028AbhFOQkC (ORCPT ); Tue, 15 Jun 2021 12:40:02 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id CF64768AFE; Tue, 15 Jun 2021 18:37:56 +0200 (CEST) Date: Tue, 15 Jun 2021 18:37:56 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Christoph Hellwig , Andrew Morton , Jan Kara , Al Viro , Greg Kroah-Hartman , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] fs: Remove anon_set_page_dirty() Message-ID: <20210615163756.GD1600@lst.de> References: <20210615162342.1669332-1-willy@infradead.org> <20210615162342.1669332-5-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210615162342.1669332-5-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 15, 2021 at 05:23:40PM +0100, Matthew Wilcox (Oracle) wrote: > Use __set_page_dirty_no_writeback() instead. This will set the dirty > bit on the page, which will be used to avoid calling set_page_dirty() > in the future. It will have no effect on actually writing the page > back, as the pages are not on any LRU lists. Looks good, Reviewed-by: Christoph Hellwig